Fix the Editor/Viewer split panel #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The issue was related to how the async loading of the meshes caused the _setEditorControls() to be called twice and apparently this duplicated the signal handlers so when clicking a mesh the signal would fire twice and the link would be selected and immediately unselected as if clicked twice. The simplest solution I found was to make sure _setEditorControls() is only called once using a flag. |
IsabelParedes
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some parts of the logic to handle the split panel.
One of the main changes is to thoroughly check whether the editor panel anchor already exists to not create a third panel down the middle. Also should be much more consistent after refreshing.