non-virtual member function marked 'override' hides virtual member function

[Schamschula]

While rebuilding xeus-sqlite 0.6.2 against xeus 4.0.0 under MacPorts (macOS 13.6.5 22G621 arm64; Xcode 15.2 15C500b) I saw the following errors:

/usr/bin/clang++ -DGUID_CFUUID -DSQLITE_DEBUG=1 -DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_EXPLAIN_COMMENTS=1 -DSQLITE_MEMDEBUG=1 -DXEUS_SQLITE_EXPORTS -DXVEGA_EXPORTS -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/include -isystem /opt/local/include -pipe -Os -DNDEBUG -I/opt/local/include -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -mmacosx-version-min=13.0 -Wunused-parameter -Wextra -Wreorder -mtune=generic -std=gnu++17 -MD -MT CMakeFiles/xeus-sqlite-static.dir/src/xvega_sqlite.cpp.o -MF CMakeFiles/xeus-sqlite-static.dir/src/xvega_sqlite.cpp.o.d -o CMakeFiles/xeus-sqlite-static.dir/src/xvega_sqlite.cpp.o -c /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xvega_sqlite.cpp
In file included from In file included from /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp::2323:
:
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/include/xeus-sqlite/xeus_sqlite_interpreter.hpp/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/include/xeus-sqlite/xeus_sqlite_interpreter.hpp::4747::5757:: error: non-virtual member function marked 'override' hides virtual member function
bool allow_stdin) override;
^
error: non-virtual member function marked 'override' hides virtual member function
bool allow_stdin) override;
^
/opt/local/include/xeus/xinterpreter.hpp:111:22: note: hidden overloaded virtual function 'xeus::xinterpreter::execute_request_impl' declared here: type mismatch at 1st parameter ('xrequest_context' vs 'int')
virtual void execute_request_impl(xrequest_context request_context,
^
/opt/local/include/xeus/xinterpreter.hpp:111:22: note: hidden overloaded virtual function 'xeus::xinterpreter::execute_request_impl' declared here: type mismatch at 1st parameter ('xrequest_context' vs 'int')
virtual void execute_request_impl(xrequest_context request_context,
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:237:39: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:237:39: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:257:39: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:257:39: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:263:39: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:263:39: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:363:56: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:363:56: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:428:64: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:428:64: error: too few arguments to function call, expected 4, have 3
nl::json::object());
^
/opt/local/include/xeus/xinterpreter.hpp:78:14: note: 'publish_execution_result' declared here
void publish_execution_result(xrequest_context, int execution_count, nl::json data, nl::json metadata);
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:446:83: error: too few arguments to function call, expected 4, have 3
publish_execution_error(jresult["ename"], jresult["evalue"], traceback);
~~~~~~~~~~~~~~~~~~~~~~~ ^
/opt/local/include/xeus/xinterpreter.hpp:79:14: note: 'publish_execution_error' declared here
void publish_execution_error(xrequest_context,
^
/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_databases_xeus-sqlite/xeus-sqlite/work/xeus-sqlite-0.6.2/src/xeus_sqlite_interpreter.cpp:446:83: error: too few arguments to function call, expected 4, have 3
publish_execution_error(jresult["ename"], jresult["evalue"], traceback);
~~~~~~~~~~~~~~~~~~~~~~~ ^
/opt/local/include/xeus/xinterpreter.hpp:79:14: note: 'publish_execution_error' declared here
void publish_execution_error(xrequest_context,
^
7 errors generated.

[Schamschula]

No change with xeus 4.0.3. It's blocking all xeus packages under MacPorts.

[Schamschula]

Now that xeus is @ 5.1.0, I still see this issue..

[alfredolavin]

Me too

[Schamschula]

It looks like #143 fixes this issue.