Skip to content

Commit 9b6036c

Browse files
committed
Use Python 3.9 for linting
1 parent 5a5c105 commit 9b6036c

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ jobs:
100100
steps:
101101
- uses: actions/checkout@v4
102102
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
103+
with:
104+
python-version: "3.9"
103105
- name: Run Linters
104106
run: |
105107
hatch run typing:test

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ repos:
3737
types_or: [yaml, html, json]
3838

3939
- repo: https://github.com/pre-commit/mirrors-mypy
40-
rev: "v1.8.0"
40+
rev: "v1.13.0"
4141
hooks:
4242
- id: mypy
4343
files: jupyter_client
4444
stages: [manual]
45-
args: ["--install-types", "--non-interactive"]
45+
args: ["--install-types", "--non-interactive", "--python-version=3.9"]
4646
additional_dependencies:
4747
["traitlets>=5.13", "ipykernel>=6.26", "jupyter_core>=5.3.2"]
4848

jupyter_client/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ async def _stdin_hook_default(self, msg: t.Dict[str, t.Any]) -> None:
241241
prompt = getpass if content.get("password", False) else input
242242

243243
try:
244-
raw_data = prompt(content["prompt"]) # type:ignore[operator]
244+
raw_data = prompt(content["prompt"])
245245
except EOFError:
246246
# turn EOFError into EOF character
247247
raw_data = "\x04"

jupyter_client/launcher.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ def launch_kernel(
6565
# If this process in running on pythonw, we know that stdin, stdout, and
6666
# stderr are all invalid.
6767
redirect_out = sys.executable.endswith("pythonw.exe")
68+
_stdout: Any
69+
_stderr: Any
6870
if redirect_out:
6971
blackhole = open(os.devnull, "w") # noqa
7072
_stdout = blackhole if stdout is None else stdout

0 commit comments

Comments
 (0)