Skip to content

Commit 5b0857f

Browse files
authored
Add support for pdf and zip binary types (#67)
* Add support for pdf and zip binary types * Refactor base64 conditions in single if
1 parent a5dd06e commit 5b0857f

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/drive.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -375,11 +375,16 @@ export class FileSystemDrive implements Contents.IDrive {
375375
let format: Contents.FileFormat;
376376
let fileContent: any = null;
377377

378-
// We assume here image, audio and video mimetypes are all and only binary files we'll encounter
378+
// We assume here image, audio, video, zip and pdf mimetypes are all and only binary files we'll encounter
379379
if (
380380
file.type &&
381-
file.type.split('/') &&
382-
['image', 'audio', 'video'].includes(file.type.split('/')[0])
381+
((file.type.split('/') &&
382+
['image', 'audio', 'video'].includes(file.type.split('/')[0])) ||
383+
[
384+
'application/zip',
385+
'application/pdf',
386+
'application/octet-stream'
387+
].includes(file.type))
383388
) {
384389
format = 'base64';
385390
} else {

0 commit comments

Comments
 (0)