Skip to content

Commit 6a81922

Browse files
committed
Fix out of band changes
1 parent 5ef91b1 commit 6a81922

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

packages/jupyter-chat/src/components/messages/message.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,14 @@ export const ChatMessage = forwardRef<HTMLDivElement, ChatMessageProps>(
7070
function messageChanged() {
7171
setMessage(props.message.content);
7272
}
73+
7374
props.message.changed.connect(messageChanged);
75+
76+
// Initialize the message when the message is re-rendered.
77+
// FIX ? This seems to be required for outofband change, to get the new value,
78+
// even if when an outofband change occurs, all the messages are deleted and
79+
// recreated.
80+
setMessage(props.message.content);
7481
return () => {
7582
props.message.changed.disconnect(messageChanged);
7683
};

packages/jupyter-chat/src/components/messages/messages.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export function ChatMessages(props: BaseMessageProps): JSX.Element {
203203
return (
204204
// extra div needed to ensure each bubble is on a new line
205205
<Box
206-
key={i}
206+
key={message.id}
207207
sx={{
208208
...(isCurrentUser && {
209209
marginLeft: props.area === 'main' ? '25%' : '10%',

0 commit comments

Comments
 (0)