Merge pull request #140 from justcoded/develop

Update error states on build tasks

Author: sgurin

helpers/notifier.js

@@ -12,6 +12,7 @@ module.exports = {
 
     console.log(`\u{1b}[31m[ ${title} ]\u{1b}[0m`);
     console.log(`\u{1b}[33m${error}\u{1b}[0m`);
+    console.log(error);
 
     return callback ? callback() : null;
   },

package.json

@@ -43,10 +43,10 @@
     "gulp-sass": "4.0.2",
     "gulp-sourcemaps": "2.6.5",
     "htmlhint-stylish": "1.0.3",
-    "node-notifier": "6.0.0",
+    "node-notifier": "7.0.0",
     "postcss-import": "12.0.1",
     "postcss-sort-media-queries": "1.4.23",
-    "rollup": "2.2.0",
+    "rollup": "2.7.1",
     "rollup-plugin-babel": "4.4.0",
     "rollup-plugin-terser": "5.3.0",
     "sass": "1.26.3"

tasks/build-js-vendors.js

@@ -30,19 +30,32 @@ module.exports = function () {
           production ? terser() : null,
         ],
         onwarn(warning, warn) {
+          // skip certain warnings
+          if (
+            warning.code === 'UNUSED_EXTERNAL_IMPORT' 
+            || warning.code === 'THIS_IS_UNDEFINED' 
+            || warning.code === 'NON_EXISTENT_EXPORT'
+          )
+            return;
+
           throw new Error(warning.message);
         },
       });
 
       const tempJs = await bundle.write({
         file: `./${global.folder.temp}/js/${global.file.vendorJsTemp}`,
-        format: 'iife',
+        format: 'esm',
         name: 'vendor',
         sourcemap: false,
       });
       const tempJsFileName = tempJs.output[0].fileName;
 
-      gulp.src(filesExist([...vendorFiles, `./${global.folder.temp}/js/${tempJsFileName}`]))
+      gulp.src(
+          filesExist([
+            ...vendorFiles,
+            `./${global.folder.temp}/js/${tempJsFileName}`,
+          ]),
+        )
         .pipe(concat(vendorFileName))
         .pipe(gulp.dest(`./${global.folder.dev}/js`));
     } catch (error) {

tasks/build-js.js

@@ -25,6 +25,14 @@ module.exports = function () {
           production ? terser() : null,
         ],
         onwarn(warning, warn) {
+          // skip certain warnings
+          if (
+            warning.code === 'UNUSED_EXTERNAL_IMPORT' 
+            || warning.code === 'THIS_IS_UNDEFINED' 
+            || warning.code === 'NON_EXISTENT_EXPORT'
+          )
+            return;
+
           throw new Error(warning.message);
         },
       });