Skip to content
This repository was archived by the owner on Jun 10, 2025. It is now read-only.

Commit f1a579b

Browse files
committed
Need to fix styles return format
1 parent 819bfc3 commit f1a579b

File tree

9 files changed

+36
-21
lines changed

9 files changed

+36
-21
lines changed

gulp-config.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ module.exports = {
1313
vendorJs: 'vendor.js',
1414
vendorJsMin: 'vendor.min.js',
1515
vendorJsTemp: 'vendor.temp.js',
16-
mainScss: 'styles.scss',
17-
mainScssMin: 'styles.min.css',
18-
vendorScss: 'vendor.scss',
19-
vendorScssMin: 'vendor.min.css',
16+
mainStyles: 'styles.scss',
17+
mainStylesMin: 'styles.min.css',
18+
vendorStyles: 'vendor.scss',
19+
vendorStylesMin: 'vendor.min.css',
2020
},
2121
buildHtml: {
2222
templates: 'src/html/templates',

gulpfile.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,16 @@
9393
requireTask(`${cfg.task.buildHtml}`, `./${cfg.folder.tasks}/`, {
9494
templates: cfg.buildHtml.templates,
9595
dest: cfg.buildHtml.dest,
96+
mainJs: cfg.file.mainJs,
97+
mainJsMin: cfg.file.mainJsMin,
98+
vendorJs: cfg.file.vendorJs,
99+
vendorJsMin: cfg.file.vendorJsMin,
100+
mainStyles: cfg.file.mainStyles,
101+
mainStylesMin: cfg.file.mainStylesMin,
102+
vendorStyles: cfg.file.vendorStyles,
103+
vendorStylesMin: cfg.file.vendorStylesMin,
96104
error: cfg.error,
105+
checkProduction: true,
97106
});
98107

99108
/**
@@ -144,8 +153,8 @@
144153
requireTask(`${cfg.task.buildStyles}`, `./${cfg.folder.tasks}/`, {
145154
src: cfg.folder.src,
146155
dest: cfg.folder.build,
147-
mainScss: cfg.file.mainScss,
148-
mainScssMin: cfg.file.mainScssMin,
156+
mainStyles: cfg.file.mainStyles,
157+
mainStylesMin: cfg.file.mainStylesMin,
149158
sortType: cfg.buildStyles.sortType,
150159
error: cfg.error,
151160
checkProduction: true,
@@ -168,8 +177,8 @@
168177
requireTask(`${cfg.task.buildStylesVendors}`, `./${cfg.folder.tasks}/`, {
169178
src: cfg.folder.src,
170179
dest: cfg.folder.build,
171-
vendorScss: cfg.file.vendorScss,
172-
vendorScssMin: cfg.file.vendorScssMin,
180+
vendorStyles: cfg.file.vendorStyles,
181+
vendorStylesMin: cfg.file.vendorStylesMin,
173182
error: cfg.error,
174183
checkProduction: true,
175184
});

src/html/partials/head/head.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
<meta charset="utf-8">
33
<meta name="viewport" content="width=device-width, initial-scale=1.0">
44
<title>Web Starter Kit</title>
5-
<link media="all" rel="stylesheet" href="css/vendor.min.css">
6-
<link media="all" rel="stylesheet" href="css/styles.min.css">
7-
</head>
5+
<link media="all" rel="stylesheet" href="@@webRoot/css/@@vendorStyles">
6+
<link media="all" rel="stylesheet" href="@@webRoot/css/@@mainStyles">
7+
</head>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
<script src="js/vendor.min.js" defer></script>
2-
<script src="js/app.min.js" defer></script>
1+
<script src="@@webRoot/js/@@vendorJs" defer></script>
2+
<script src="@@webRoot/js/@@mainJs" defer></script>

tasks/build-html.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ module.exports = function (options) {
1212
prefix: '@@',
1313
basepath: `./${options.templates}`,
1414
indent: true,
15+
context: {
16+
mainJs: options.isProduction ? options.mainJsMin : options.mainJs,
17+
vendorJs: options.isProduction ? options.vendorJsMin : options.vendorJs,
18+
mainStyles: options.isProduction ? options.mainStylesMin : options.mainStyles,
19+
vendorStyles: options.isProduction ? options.vendorStylesMin : options.vendorStyles,
20+
},
1521
};
1622

1723
options.error.title = 'HTML compiling error';

tasks/build-js-vendors.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ module.exports = function (options) {
2828
return done();
2929
} else if (noneES6) {
3030
return gulp.src(filesExist(jsVendors.es5))
31-
.pipe(concat(options.vendorJsMin))
31+
.pipe(concat(options.isProduction ? options.vendorJsMin : options.vendorJs))
3232
.pipe(gulpif(options.isProduction, uglify()))
3333
.pipe(gulp.dest(`./${options.dest}/js`));
3434
} else if (noneES5) {
3535
return browserify({ entries: jsVendors.es6 })
3636
.transform('babelify', babelConfig)
3737
.bundle().on('error', notify.onError(options.error))
38-
.pipe(source(options.vendorJsMin))
38+
.pipe(source(options.isProduction ? options.vendorJsMin : options.vendorJs))
3939
.pipe(gulpif(options.isProduction, buffer()))
4040
.pipe(gulpif(options.isProduction, uglify()))
4141
.pipe(gulp.dest(`./${options.dest}/js`));
@@ -47,7 +47,7 @@ module.exports = function (options) {
4747
.pipe(gulp.dest(`./${options.temp}/js`))
4848
.on('end', () => {
4949
gulp.src(filesExist([...jsVendors.es5, `./${options.temp}/js/${options.vendorJsTemp}`]))
50-
.pipe(concat(options.vendorJsMin))
50+
.pipe(concat(options.isProduction ? options.vendorJsMin : options.vendorJs))
5151
.pipe(gulpif(options.isProduction, uglify()))
5252
.pipe(gulp.dest(`./${options.dest}/js`))
5353
});

tasks/build-js.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = function (options) {
2424
})
2525
.transform('babelify', babelConfig)
2626
.bundle().on('error', notify.onError(options.error))
27-
.pipe(source(options.mainJsMin))
27+
.pipe(source(options.isProduction ? options.mainJsMin : options.mainJs))
2828
.pipe(gulpif(options.isProduction, buffer()))
2929
.pipe(gulpif(options.isProduction, uglify()))
3030
.pipe(gulp.dest(`./${options.dest}/js`));

tasks/build-styles-vendors.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ module.exports = function (options) {
2424

2525
return () => {
2626
return gulp
27-
.src(`./${options.src}/vendor_entries/${options.vendorScss}`)
28-
.pipe(rename(options.vendorScssMin))
27+
.src(`./${options.src}/vendor_entries/${options.vendorStyles}`)
28+
.pipe(rename(options.isProduction ? options.vendorStylesMin : options.vendorStyles))
2929
.pipe(sass.sync())
3030
.on('error', notify.onError(options.error))
3131
.pipe(postcss(plugins))

tasks/build-styles.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ module.exports = function (options) {
2727
options.isProduction ? plugins.push(cssnano()) : false;
2828

2929
return () => {
30-
return gulp.src(`./${options.src}/scss/${options.mainScss}`)
31-
.pipe(rename(options.mainScssMin))
30+
return gulp.src(`./${options.src}/scss/${options.mainStyles}`)
31+
.pipe(rename(options.isProduction ? options.mainStylesMin : options.mainStyles))
3232
.pipe(gulpif(!options.isProduction, sourcemaps.init({ loadMaps: true, })))
3333
.pipe(sass.sync({ sourceMap: !options.isProduction, }))
3434
.on('error', notify.onError(options.error))

0 commit comments

Comments
 (0)