Update popup content dynamically #2347
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a separate HTML and JavaScript files for each popup, use just single popup for everything and parse the content based on the
page.popupData. The refactor also eliminates some duplicate code in the popup files.The content should now change in real time according to database state (open/locked/login/default) if the popup is open.
Other minor changes:
browserAction.show()is renamed tobrowserAction.updatePopupIcon().browserAction.showDefault()is renamed tobrowserAction.updatePopup().TODO:
get_statuson Firefox every time the popup is openedFixes #76.