Merge pull request #179 from EmperorArthur/update_holes

Add Multiple Options for Hole Configuration

Author: EmperorArthur

.gitignore

@@ -1,8 +1,12 @@
 
 ignore/
-gridfinity-rebuilt.json
-gridfinity-rebuilt-bins.json
 stl/
 batch/
 site/
-*.json
+/*.json
+
+# From https://github.com/github/gitignore/blob/main/Python.gitignore
+# Byte-compiled / optimized / DLL files
+__pycache__/
+*.py[cod]
+*$py.class

generic-helpers.scad

@@ -5,6 +5,8 @@
 
 function clp(x,a,b) = min(max(x,a),b);
 
+function is_even(number) = (number%2)==0;
+
 module rounded_rectangle(length, width, height, rad) {
     linear_extrude(height)
     offset(rad)

gridfinity-rebuilt-baseplate.scad

@@ -1,5 +1,6 @@
 include <gridfinity-rebuilt-utility.scad>
 include <standard.scad>
+use <gridfinity-rebuilt-holes.scad>
 
 // ===== INFORMATION ===== //
 /*
@@ -49,23 +50,29 @@ fity = 0; // [-1:0.1:1]
 // baseplate styles
 style_plate = 0; // [0: thin, 1:weighted, 2:skeletonized, 3: screw together, 4: screw together minimal]
 
-// enable magnet hole
-enable_magnet = true;
 
 // hole styles
 style_hole = 2; // [0:none, 1:countersink, 2:counterbore]
 
+/* [Magnet Hole] */
+// Baseplate will have holes for 6mm Diameter x 2mm high magnets.
+enable_magnet = true;
+// Magnet holes will have crush ribs to hold the magnet.
+crush_ribs = true;
+// Magnet holes will have a chamfer to ease insertion.
+chamfer_holes = true;
+
+hole_options = bundle_hole_options(refined_hole=false, magnet_hole=enable_magnet, screw_hole=false, crush_ribs=crush_ribs, chamfer=chamfer_holes, supportless=false);
 
 // ===== IMPLEMENTATION ===== //
-screw_together = (style_plate == 3 || style_plate == 4);
 
 color("tomato")
-gridfinityBaseplate(gridx, gridy, l_grid, distancex, distancey, style_plate, enable_magnet, style_hole, fitx, fity);
+gridfinityBaseplate(gridx, gridy, l_grid, distancex, distancey, style_plate, hole_options, style_hole, fitx, fity);
 
 
 // ===== CONSTRUCTION ===== //
 
-module gridfinityBaseplate(gridx, gridy, length, dix, diy, sp, sm, sh, fitx, fity) {
+module gridfinityBaseplate(gridx, gridy, length, dix, diy, sp, hole_options, sh, fitx, fity) {
 
     assert(gridx > 0 || dix > 0, "Must have positive x grid amount!");
     assert(gridy > 0 || diy > 0, "Must have positive y grid amount!");
@@ -75,7 +82,7 @@ module gridfinityBaseplate(gridx, gridy, length, dix, diy, sp, sm, sh, fitx, fit
     dx = max(gx*length-bp_xy_clearance, dix);
     dy = max(gy*length-bp_xy_clearance, diy);
 
-    off = calculate_off(sp, sm, sh);
+    off = calculate_offset(sp, hole_options[1], sh);
 
     offsetx = dix < dx ? 0 : (gx*length-bp_xy_clearance-dix)/2*fitx*-1;
     offsety = diy < dy ? 0 : (gy*length-bp_xy_clearance-diy)/2*fity*-1;
@@ -85,7 +92,7 @@ module gridfinityBaseplate(gridx, gridy, length, dix, diy, sp, sm, sh, fitx, fit
         mirror([0,0,1])
         rounded_rectangle(dx, dy, h_base+off, r_base);
 
-        gridfinityBase(gx, gy, length, 1, 1, 0, 0.5, false);
+        gridfinityBase(gx, gy, length, 1, 1, bundle_hole_options(), 0.5, false);
 
         translate([offsetx,offsety,h_base-0.6])
         rounded_rectangle(dx*2, dy*2, h_base*2, r_base);
@@ -105,33 +112,36 @@ module gridfinityBaseplate(gridx, gridy, length, dix, diy, sp, sm, sh, fitx, fit
 
 
                 hole_pattern(){
-                    if (sm) block_base_hole(1);
+                    mirror([0, 0, 1])
+                    block_base_hole(hole_options);
 
-                    translate([0,0,-off])
+                    translate([0,0,-off-TOLLERANCE])
                     if (sh == 1) cutter_countersink();
                     else if (sh == 2) cutter_counterbore();
                 }
             }
         }
-        if (sp == 3 || sp ==4) cutter_screw_together(gx, gy, off);
+        screw_together = sp == 3 || sp == 4;
+        if (screw_together) cutter_screw_together(gx, gy, off);
     }
 
 }
 
-function calculate_off(sp, sm, sh) =
-    screw_together
-        ? 6.75
-        :sp==0
-            ?0
-            : sp==1
-                ?bp_h_bot
-                :h_skel + (sm
-                    ?h_hole
-                    : 0)+(sh==0
-                        ? d_screw
-                        : sh==1
-                            ?d_cs
-                            :h_cb);
+function calculate_offset(style_plate, enable_magnet, style_hole) =
+    assert(style_plate >=0 && style_plate <=4)
+    let (screw_together = style_plate == 3 || style_plate == 4)
+    screw_together ? 6.75 :
+    style_plate==0 ? 0 :
+    style_plate==1 ? bp_h_bot :
+    calculate_offset_skeletonized(enable_magnet, style_hole);
+
+function calculate_offset_skeletonized(enable_magnet, style_hole) =
+    h_skel + (enable_magnet ? MAGNET_HOLE_DEPTH : 0) +
+    (
+        style_hole==0 ? d_screw :
+        style_hole==1 ? BASEPLATE_SCREW_COUNTERSINK_ADDITIONAL_RADIUS : // Only works because countersink is at 45 degree angle!
+        BASEPLATE_SCREW_COUNTERBORE_HEIGHT
+    );
 
 module cutter_weight() {
     union() {
@@ -156,23 +166,19 @@ module hole_pattern(){
 }
 
 module cutter_countersink(){
-    cylinder(r = r_hole1+d_clear, h = 100*h_base, center = true);
-    translate([0,0,d_cs])
-    mirror([0,0,1])
-    hull() {
-        cylinder(h = d_cs+10, r=r_hole1+d_clear);
-        translate([0,0,d_cs])
-        cylinder(h=d_cs+10, r=r_hole1+d_clear+d_cs);
-    }
+    screw_hole(SCREW_HOLE_RADIUS + d_clear, 2*h_base,
+        false, BASEPLATE_SCREW_COUNTERSINK_ADDITIONAL_RADIUS);
 }
 
 module cutter_counterbore(){
-    cylinder(h=100*h_base, r=r_hole1+d_clear, center=true);
-    difference() {
-        cylinder(h = 2*(h_cb+0.2), r=r_cb, center=true);
-        copy_mirror([0,1,0])
-        translate([-1.5*r_cb,r_hole1+d_clear+0.1,h_cb-h_slit])
-        cube([r_cb*3,r_cb*3, 10]);
+    screw_radius = SCREW_HOLE_RADIUS + d_clear;
+    counterbore_height = BASEPLATE_SCREW_COUNTERBORE_HEIGHT + 2*LAYER_HEIGHT;
+    union(){
+        cylinder(h=2*h_base, r=screw_radius);
+        difference() {
+            cylinder(h = counterbore_height, r=BASEPLATE_SCREW_COUNTERBORE_RADIUS);
+            make_hole_printable(screw_radius, BASEPLATE_SCREW_COUNTERBORE_RADIUS, counterbore_height);
+        }
     }
 }
 
@@ -185,7 +191,7 @@ module profile_skeleton() {
             translate([l_grid/2-d_hole_from_side,l_grid/2-d_hole_from_side,0])
             minkowski() {
                 square([l,l]);
-                circle(r_hole2+r_skel+2);
+                circle(MAGNET_HOLE_RADIUS+r_skel+2);
            }
         }
         circle(r_skel);

gridfinity-rebuilt-bins.scad

@@ -72,17 +72,30 @@ style_tab = 1; //[0:Full,1:Auto,2:Left,3:Center,4:Right,5:None]
 style_lip = 0; //[0: Regular lip, 1:remove lip subtractively, 2: remove lip and retain height]
 // scoop weight percentage. 0 disables scoop, 1 is regular scoop. Any real number will scale the scoop.
 scoop = 1; //[0:0.1:1]
-// only cut magnet/screw holes at the corners of the bin to save uneccesary print time
-only_corners = false;
 
 /* [Base] */
-style_hole = 4; // [0:no holes, 1:magnet holes only, 2: magnet and screw holes - no printable slit, 3: magnet and screw holes - printable slit, 4: Gridfinity Refined hole - no glue needed]
 // number of divisions per 1 unit of base along the X axis. (default 1, only use integers. 0 means automatically guess the right division)
 div_base_x = 0;
 // number of divisions per 1 unit of base along the Y axis. (default 1, only use integers. 0 means automatically guess the right division)
 div_base_y = 0;
 
-
+/* [Base Hole Options] */
+// only cut magnet/screw holes at the corners of the bin to save uneccesary print time
+only_corners = false;
+//Use gridfinity refined hole style. Not compatible with magnet_holes!
+refined_holes = true;
+// Base will have holes for 6mm Diameter x 2mm high magnets.
+magnet_holes = false;
+// Base will have holes for M3 screws.
+screw_holes = false;
+// Magnet holes will have crush ribs to hold the magnet.
+crush_ribs = true;
+// Magnet/Screw holes will have a chamfer to ease insertion.
+chamfer_holes = true;
+// Magnet/Screw holes will be printed so supports are not needed.
+printable_hole_top = true;
+
+hole_options = bundle_hole_options(refined_holes, magnet_holes, screw_holes, crush_ribs, chamfer_holes, printable_hole_top);
 
 // ===== IMPLEMENTATION ===== //
 
@@ -98,7 +111,7 @@ gridfinityInit(gridx, gridy, height(gridz, gridz_define, style_lip, enable_zsnap
         cutCylinders(n_divx=cdivx, n_divy=cdivy, cylinder_diameter=cd, cylinder_height=ch, coutout_depth=c_depth, orientation=c_orientation, chamfer=c_chamfer);
     }
 }
-gridfinityBase(gridx, gridy, l_grid, div_base_x, div_base_y, style_hole, only_corners=only_corners);
+gridfinityBase(gridx, gridy, l_grid, div_base_x, div_base_y, hole_options, only_corners=only_corners);
 }