Skip to content

Fix broken parameters in baseplate options #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix broken parameters in baseplate options #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gridfinity-rebuilt-baseplate.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ module gridfinityBaseplate(grid_size_bases, length, min_size_mm, sp, hole_option
assert(grid_size_bases.y > 0 || min_size_mm.y > 0,
"Must have positive y grid amount!");

additional_height = calculate_offset(sp, hole_options[1], sh);
additional_height = calculate_offset(sp, hole_options[2], sh);

// Final height of the baseplate. In mm.
baseplate_height_mm = additional_height + BASEPLATE_HEIGHT;
Expand Down Expand Up @@ -228,7 +228,7 @@ function calculate_offset(style_plate, enable_magnet, style_hole) =
function calculate_offset_skeletonized(enable_magnet, style_hole) =
h_skel + (enable_magnet ? MAGNET_HOLE_DEPTH : 0) +
(
style_hole==0 ? d_screw :
style_hole==0 ? 0 :
style_hole==1 ? BASEPLATE_SCREW_COUNTERSINK_ADDITIONAL_RADIUS : // Only works because countersink is at 45 degree angle!
BASEPLATE_SCREW_COUNTERBORE_HEIGHT
);
Expand Down