Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 27, 2025

Use a raw string to prevent LaTeX codes from being interpreted as escape sequences.

/nix/store/cfapjd2rvqrpry4grb0kljnp8bvnvfxz-python3-3.13.8/lib/python3.13/ast.py:50: in parse
    return compile(source, filename, mode, flags,
E     File "/build/source/keras/src/quantizers/gptq_test.py", line 37
E       matrix $\hat{W}$ that minimizes the mean squared error of the layer's
E               ^^
E   SyntaxError: invalid escape sequence '\h'

This avoids `SyntaxError: invalid escape sequence '\h`
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @GaetanLepage, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a SyntaxError by modifying how a specific text string is defined. By converting the string to a raw string, the change ensures that special characters, particularly backslashes, are interpreted literally rather than as escape sequences, thus preventing parsing errors and maintaining the intended content of the string.

Highlights

  • Bug Fix: Resolved a SyntaxError: invalid escape sequence that occurred due to LaTeX-like codes within the CALIBRATION_TEXT string.
  • String Handling: The CALIBRATION_TEXT variable has been converted to a raw string literal to ensure that backslashes are treated as literal characters and not as escape sequences.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a SyntaxError in keras/src/quantizers/gptq_test.py. The error, invalid escape sequence '\h', originates from the CALIBRATION_TEXT multiline string which contains LaTeX-style markup such as \hat{W}. The Python interpreter attempts to parse \h as an escape sequence, which is invalid. The fix correctly converts the string to a raw string literal by adding an r prefix (r"""..."""), ensuring backslashes are treated as literal characters. This change is correct and effectively resolves the syntax error.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.63%. Comparing base (960133e) to head (ec3a9b4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21790   +/-   ##
=======================================
  Coverage   82.63%   82.63%           
=======================================
  Files         577      577           
  Lines       59321    59321           
  Branches     9300     9300           
=======================================
  Hits        49020    49020           
  Misses       7913     7913           
  Partials     2388     2388           
Flag Coverage Δ
keras 82.45% <ø> (ø)
keras-jax 63.32% <ø> (ø)
keras-numpy 57.55% <ø> (ø)
keras-openvino 34.29% <ø> (ø)
keras-tensorflow 64.11% <ø> (ø)
keras-torch 63.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 30, 2025
@hertschuh hertschuh merged commit a0004ee into keras-team:master Oct 30, 2025
10 of 12 checks passed
@GaetanLepage GaetanLepage deleted the r-string branch October 30, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants