-
Notifications
You must be signed in to change notification settings - Fork 19.7k
Fix: use raw string for CALIBRATION_TEXT #21790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This avoids `SyntaxError: invalid escape sequence '\h`
Summary of ChangesHello @GaetanLepage, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a SyntaxError in keras/src/quantizers/gptq_test.py. The error, invalid escape sequence '\h', originates from the CALIBRATION_TEXT multiline string which contains LaTeX-style markup such as \hat{W}. The Python interpreter attempts to parse \h as an escape sequence, which is invalid. The fix correctly converts the string to a raw string literal by adding an r prefix (r"""..."""), ensuring backslashes are treated as literal characters. This change is correct and effectively resolves the syntax error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21790 +/- ##
=======================================
Coverage 82.63% 82.63%
=======================================
Files 577 577
Lines 59321 59321
Branches 9300 9300
=======================================
Hits 49020 49020
Misses 7913 7913
Partials 2388 2388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hertschuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Use a raw string to prevent LaTeX codes from being interpreted as escape sequences.