Skip to content

Commit aba479b

Browse files
committed
chore: #99 Suppress unchecked casts warning on getting the tuning json in JacksonUtilsTest.
1 parent 2b08b32 commit aba479b

File tree

1 file changed

+24
-8
lines changed

1 file changed

+24
-8
lines changed

kgstatsSrv/src/test/java/ru/klavogonki/statistics/util/JacksonUtilsTest.java

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ void existingPlayer() {
9090
.hasCar(Car.F1.id)
9191
.hasColor("#BF1300");
9292

93-
Map<String, Integer> tuning = (Map<String, Integer>) car.getTuning();
93+
Map<String, Integer> tuning = getNonEmptyTuning(car);
9494
assertThat(tuning)
9595
.hasSize(2)
9696
.containsEntry("0", 3)
@@ -135,9 +135,7 @@ void playerWithPersonalCarId() {
135135
.hasCar(Car.CARAVEL.personalId)
136136
.hasColor("#000000");
137137

138-
List<Integer> tuning = (List<Integer>) car.getTuning();
139-
assertThat(tuning)
140-
.isEmpty();
138+
assertEmptyTunning(car);
141139
}
142140

143141
@Test
@@ -178,9 +176,7 @@ void brandNewPlayer() {
178176
.hasCar(Car.ZAZ_965.id)
179177
.hasColor("#777777");
180178

181-
List<Integer> tuning = (List<Integer>) car.getTuning();
182-
assertThat(tuning)
183-
.isEmpty();
179+
assertEmptyTunning(car);
184180
}
185181

186182
@Test
@@ -221,7 +217,7 @@ void klavoMechanicWithHiddenProfile() {
221217
.hasCar(Car.AUDI_TT.id)
222218
.hasColor("#893425");
223219

224-
Map<String, Integer> tuning = (Map<String, Integer>) car.getTuning();
220+
Map<String, Integer> tuning = getNonEmptyTuning(car);
225221
assertThat(tuning)
226222
.hasSize(1)
227223
.containsEntry("1", 1);
@@ -258,6 +254,26 @@ private void logPlayerSummary(final GetSummaryResponse summary) {
258254
logger.info("Player summary: ");
259255
logger.info(summary);
260256
}
257+
258+
private void assertEmptyTunning(ru.klavogonki.openapi.model.Car car) {
259+
List<Integer> tuning = getEmptyTuning(car);
260+
261+
assertThat(tuning).isEmpty();
262+
}
263+
264+
@SuppressWarnings("unchecked")
265+
private List<Integer> getEmptyTuning(ru.klavogonki.openapi.model.Car car) {
266+
return (List<Integer>) car.getTuning();
267+
}
268+
269+
@SuppressWarnings("unchecked")
270+
private Map<String, Integer> getNonEmptyTuning(ru.klavogonki.openapi.model.Car car) {
271+
Map<String, Integer> tuning = (Map<String, Integer>) car.getTuning();
272+
273+
assertThat(tuning).isNotEmpty();
274+
275+
return tuning;
276+
}
261277
}
262278

263279
@Nested

0 commit comments

Comments
 (0)