Skip to content

Spawn delay in garbage mode is incorrect #128

@kirjavascript

Description

@kirjavascript

discussion from discord:

zohassadar
 — 
Today at 15:52
https://github.com/kirjavascript/TetrisGYM/blob/9ad2faacc6cfd919782330659468028aea04533b/src/playstate/garbage.asm#L37-L39

@Kirjava I think setting vramRow to 0 here would add 3 or 4 frames to the spawn delay when garbage is added.
Kirjava
 — 
Today at 15:54
hmm, that's annoying because otherwise the rendering won't be correct
I guess we have to either:

    write some custom rendering for garbage
    adjust the spawn delay code to account for garbage

zohassadar
 — 
Today at 15:55
It can be worked around if the garbage is added on the same frame as the end of the line clear animation
i don't know how much of the scoring logic needs to be done though
Kirjava
 — 
Today at 15:56
sometimes garbage is added without a line clear
zohassadar
 — 
Today at 15:56
Oh yeah

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions