use retry.UntilSucess

Signed-off-by: aicee <hhbin2000@foxmail.com>

Author: zrggw

pkg/controller/security/manager_test.go

@@ -24,6 +24,7 @@ import (
 	"github.com/agiledragon/gomonkey/v2"
 	"github.com/stretchr/testify/assert"
 	"istio.io/istio/pkg/security"
+	"istio.io/istio/pkg/test/util/retry"
 
 	camock "kmesh.net/kmesh/pkg/controller/security/mock"
 )
@@ -165,25 +166,27 @@ func runTestretryFetchCert(t *testing.T) {
 	patches2.Reset()
 
 	secretManager.SendCertRequest(identity, RETRY)
-	time.Sleep(2000 * time.Millisecond)
-	for {
-		cert := secretManager.GetCert(identity)
-		if cert != nil {
-			secretManager.certsCache.mu.RLock()
-			hasCert := cert.cert != nil
-			secretManager.certsCache.mu.RUnlock()
-			if hasCert {
-				break
+
+	err = retry.UntilSuccess(
+		func() error {
+			cert := secretManager.GetCert(identity)
+			if cert != nil {
+				secretManager.certsCache.mu.RLock()
+				hasCert := cert.cert != nil
+				secretManager.certsCache.mu.RUnlock()
+				if hasCert {
+					return nil
+				}
 			}
-		}
-		time.Sleep(100 * time.Millisecond)
+			return fmt.Errorf("cert not found for identity %s", identity)
+		},
+		retry.Delay(100*time.Millisecond),
+		retry.Timeout(6*time.Second),
+	)
+
+	if err != nil {
+		t.Errorf("Failed to fetch cert after retry: %v", err)
 	}
 
-	cert := secretManager.GetCert(identity)
-	assert.NotNil(t, cert)
-	secretManager.certsCache.mu.RLock()
-	assert.NotNil(t, cert.cert)
-	secretManager.certsCache.mu.RUnlock()
-
 	close(stopCh)
 }