Skip to content

Conversation

@matzew
Copy link
Contributor

@matzew matzew commented Apr 14, 2025

Fixes #4326

Proposed Changes

  • Removing deprecated DefaultPartition configuration. Strimz does not even support older versions like 3.2, where this was not deprecated

Release Note

Remove of deprecated DefaultPartition config. This feature is deprecated since Apache Kafka 3.3. See KIP-794for more

Docs

@knative-prow
Copy link

knative-prow bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2025
@knative-prow knative-prow bot requested review from creydr and pierDipi April 14, 2025 15:15
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.96%. Comparing base (4f166b7) to head (159593e).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4327   +/-   ##
=======================================
  Coverage   29.96%   29.96%           
=======================================
  Files         290      290           
  Lines       19435    19435           
=======================================
  Hits         5823     5823           
  Misses      13159    13159           
  Partials      453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew
Copy link
Contributor Author

matzew commented Apr 14, 2025

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Apr 15, 2025

/retest

@matzew
Copy link
Contributor Author

matzew commented Apr 15, 2025

/test integration-tests

@matzew
Copy link
Contributor Author

matzew commented Apr 15, 2025

/test reconciler-tests

@matzew
Copy link
Contributor Author

matzew commented Apr 15, 2025

/test integration-tests

@matzew
Copy link
Contributor Author

matzew commented Apr 15, 2025

/test reconciler-tests

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Apr 15, 2025

/test reconciler-tests

@matzew
Copy link
Contributor Author

matzew commented Apr 16, 2025

/retest

@matzew
Copy link
Contributor Author

matzew commented Apr 17, 2025

/retest-required

2 similar comments
@matzew
Copy link
Contributor Author

matzew commented Apr 17, 2025

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Apr 22, 2025

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Apr 23, 2025

/test integration-tests

@matzew
Copy link
Contributor Author

matzew commented Apr 23, 2025

/test reconciler-tests

@matzew
Copy link
Contributor Author

matzew commented Apr 24, 2025

/retest

@matzew
Copy link
Contributor Author

matzew commented Apr 28, 2025

/retest-required

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented May 22, 2025

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Aug 5, 2025

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Aug 6, 2025

/retest

…ven support older versions like 3.2, where this was not deprecated

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the remove_DefaultPartitioner_setting branch from 5197620 to 159593e Compare August 8, 2025 07:12
@creydr
Copy link
Contributor

creydr commented Aug 15, 2025

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Oct 21, 2025

/retest

@knative-prow
Copy link

knative-prow bot commented Oct 21, 2025

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing-kafka-broker_main 159593e link true /test reconciler-tests
integration-tests_eventing-kafka-broker_main 159593e link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DefaultPartitioner is deprecated

2 participants