-
Notifications
You must be signed in to change notification settings - Fork 142
[Release 1.18] Upgrade mvn and go dependencies #4562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 1.18] Upgrade mvn and go dependencies #4562
Conversation
|
Welcome @kwassell-ibm! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉 |
|
Hi @kwassell-ibm. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.18 #4562 +/- ##
=============================================
Coverage 29.99% 29.99%
=============================================
Files 290 290
Lines 19338 19338
=============================================
Hits 5801 5801
Misses 13083 13083
Partials 454 454 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Blocked by - knative/hack#447 |
|
hack change merged - i bumped the dep in this PR |
|
/lgtm |
31c71a3 to
3ec117e
Compare
3ec117e to
3b9e592
Compare
|
/retest |
|
/retest The failures isn't very promising - I'm unfamiliar if it's a flake or not |
|
/retest some failures are because our CI was running too many jobs that require clusters |
|
/retest |
|
Need to pull in this change |
|
/retest |
1 similar comment
|
/retest |
Cali0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso, kwassell-ibm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Cali0707 confirmed failures are known flakes - will override /override reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.18 |
|
@dprotaso: Overrode contexts on behalf of dprotaso: reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.18, reconciler-tests_eventing-kafka-broker_release-1.18 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "reconciler-tests_eventing-kafka-broker_release-1.18" |
|
@dprotaso: Overrode contexts on behalf of dprotaso: reconciler-tests_eventing-kafka-broker_release-1.18 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
df474c0
into
knative-extensions:release-1.18
Fixes #
Updates dependencies present in the 1.18 release branch so users on Kubernetes 1.31 receive security fixes.
Proposed Changes