Skip to content

Conversation

@kwassell-ibm
Copy link

Fixes #

Updates dependencies present in the 1.18 release branch so users on Kubernetes 1.31 receive security fixes.

Proposed Changes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dprotaso / name: Dave Protasowski (3b9e592, 3dfb617)
  • ✅ login: kwassell-ibm / name: Katie Wassell (612af4c)

@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

Welcome @kwassell-ibm! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

Hi @kwassell-ibm. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2025
@dprotaso
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2025
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.99%. Comparing base (7361675) to head (3dfb617).
⚠️ Report is 1 commits behind head on release-1.18.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.18    #4562   +/-   ##
=============================================
  Coverage         29.99%   29.99%           
=============================================
  Files               290      290           
  Lines             19338    19338           
=============================================
  Hits               5801     5801           
  Misses            13083    13083           
  Partials            454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Contributor

Blocked by - knative/hack#447

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@dprotaso
Copy link
Contributor

hack change merged - i bumped the dep in this PR

@dprotaso
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2025
@dprotaso
Copy link
Contributor

/retest

@dprotaso
Copy link
Contributor

dprotaso commented Oct 22, 2025

/retest

The failures isn't very promising - I'm unfamiliar if it's a flake or not

@dprotaso
Copy link
Contributor

/retest

some failures are because our CI was running too many jobs that require clusters

@dprotaso
Copy link
Contributor

/retest

@dprotaso
Copy link
Contributor

Need to pull in this change

knative-extensions/reconciler-test#838

@dprotaso
Copy link
Contributor

/retest

1 similar comment
@dprotaso
Copy link
Contributor

/retest

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso, kwassell-ibm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor

@Cali0707 confirmed failures are known flakes - will override

/override reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.18
/override reconciler-tests_eventing-kafka-broker_release-1.18

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.18, reconciler-tests_eventing-kafka-broker_release-1.18

In response to this:

@Cali0707 confirmed failures are known flakes - will override

/override reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.18
/override reconciler-tests_eventing-kafka-broker_release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Contributor

/override "reconciler-tests_eventing-kafka-broker_release-1.18"

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: reconciler-tests_eventing-kafka-broker_release-1.18

In response to this:

/override "reconciler-tests_eventing-kafka-broker_release-1.18"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit df474c0 into knative-extensions:release-1.18 Oct 23, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants