refactor(Core.Application.Pipelines.Authorization): improve role matching logic

Author: ahmet-cetinkaya

src/Core.Application/Pipelines/Authorization/AuthorizationBehavior.cs

@@ -40,19 +40,21 @@ private bool isHasRequiredRole(IEnumerable<string> identityRoles, ReadOnlySpan<c
     {
         bool isMatch = false;
         foreach (var role in identityRoles)
-            for (int i = 0; i < requiredRoleClaims.Length; ++i)
+        {
+            for (int i = 0, j = 0; i < requiredRoleClaims.Length; ++i)
             {
-                if (requiredRoleClaims[i] == ',')
-                    continue;
-
-                if (requiredRoleClaims[i] == role[i])
+                if (requiredRoleClaims[i] == role[j])
+                {
                     isMatch = true;
+                    if (j + 1 < role.Length) ++j;
+                }
                 else
                 {
                     isMatch = false;
-                    break;
+                    j = 0;
                 }
             }
+        }
 
         return isMatch;
     }

src/tests/Core.Application.Tests/Core.Application.Tests/Pipelines/AuthorizationBehaviorTests.cs

@@ -25,7 +25,7 @@ public async Task Handle_ValidRequest_ReturnsResponse()
 
     public class ValidSecuredRequest : IRequest<int>, ISecuredRequest
     {
-        public IEnumerable<string> IdentityRoles { get; set; }
+        public IEnumerable<string> IdentityRoles { get; set; } = [];
         public ReadOnlySpan<char> RequiredRoleClaims => "".AsSpan();
     }
 
@@ -44,7 +44,7 @@ await Assert.ThrowsAsync<AuthenticationException>(
 
     public class InvalidSecuredRequest : IRequest<int>, ISecuredRequest
     {
-        public IEnumerable<string> IdentityRoles { get; set; }
+        public IEnumerable<string> IdentityRoles { get; set; } = [];
         public ReadOnlySpan<char> RequiredRoleClaims => "".AsSpan();
     }
 
@@ -69,7 +69,7 @@ await Assert.ThrowsAsync<AuthorizationException>(
 
     public class SecuredRequestWithRequiredRoleClaims : IRequest<int>, ISecuredRequest
     {
-        public IEnumerable<string> IdentityRoles { get; set; }
+        public IEnumerable<string> IdentityRoles { get; set; } = [];
         public ReadOnlySpan<char> RequiredRoleClaims => "admin".AsSpan();
     }
 
@@ -94,7 +94,7 @@ public async Task Handle_ValidRequest_WithRequiredRoleClaims_ReturnsResponse()
 
     public class SecuredRequestWithoutRequiredRoleClaims : IRequest<int>, ISecuredRequest
     {
-        public IEnumerable<string> IdentityRoles { get; set; }
-        public ReadOnlySpan<char> RequiredRoleClaims => "admin".AsSpan();
+        public IEnumerable<string> IdentityRoles { get; set; } = [];
+        public ReadOnlySpan<char> RequiredRoleClaims => "editor,admin".AsSpan();
     }
 }