fix: order of fallbacks matters

coltenkrauter · coltenkrauter · commit c0f2f69e7d4f · 2025-04-24T08:24:58.000-06:00
diff --git a/dist/index.js b/dist/index.js
@@ -81589,12 +81589,11 @@ async function getPullBlocks(pull, slack, withUserMentions) {
             username,
         });
         const displayName = slackUser?.profile?.display_name || slackUser?.profile?.real_name_normalized || username;
-        const imageUrl = slackUser?.profile?.image_512 ||
-            slackUser?.profile?.image_192 ||
-            slackUser?.profile?.image_72 ||
+        const imageUrl = slackUser?.profile?.image_72 ||
             slackUser?.profile?.image_48 ||
             slackUser?.profile?.image_32 ||
-            slackUser?.profile?.image_24;
+            slackUser?.profile?.image_24 ||
+            slackUser?.profile?.image_192;
         activityBlocks.push({
             elements: [
                 {
@@ -90388,7 +90387,7 @@ module.exports = {"version":"3.17.0"};
 /***/ 8330:
 /***/ ((module) => {
 
-module.exports = /*#__PURE__*/JSON.parse('{"UU":"@krauters/github-notifier","rE":"1.2.0","TB":"https://buymeacoffee.com/coltenkrauter"}');
+module.exports = /*#__PURE__*/JSON.parse('{"UU":"@krauters/github-notifier","rE":"1.2.1","TB":"https://buymeacoffee.com/coltenkrauter"}');
 
 /***/ })
 
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@krauters/github-notifier",
   "description": "GitHub Notifier by Krauters – Post Open Pull Requests to Slack",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "author": "Colten Krauter <coltenkrauter>",
   "type": "module",
   "homepage": "https://buymeacoffee.com/coltenkrauter",
diff --git a/src/utils/slack/blocks.ts b/src/utils/slack/blocks.ts
@@ -198,12 +198,11 @@ export async function getPullBlocks(pull: Pull, slack: SlackClient, withUserMent
 
 		const displayName = slackUser?.profile?.display_name || slackUser?.profile?.real_name_normalized || username
 		const imageUrl =
-			slackUser?.profile?.image_512 ||
-			slackUser?.profile?.image_192 ||
 			slackUser?.profile?.image_72 ||
 			slackUser?.profile?.image_48 ||
 			slackUser?.profile?.image_32 ||
-			slackUser?.profile?.image_24
+			slackUser?.profile?.image_24 ||
+			slackUser?.profile?.image_192
 
 		activityBlocks.push({
 			elements: [
diff --git a/test/utils/slack/blocks.test.ts b/test/utils/slack/blocks.test.ts
@@ -216,10 +216,6 @@ describe('Utils: Slack', () => {
 				}
 
 				/* eslint-disable @typescript-eslint/naming-convention */
-				await testImageFallback(
-					{ image_512: 'https://example.com/image512.jpg' },
-					'https://example.com/image512.jpg',
-				)
 				await testImageFallback(
 					{ image_192: 'https://example.com/image192.jpg' },
 					'https://example.com/image192.jpg',

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@krauters/github-notifier",`
`3`	`3`	`"description": "GitHub Notifier by Krauters – Post Open Pull Requests to Slack",`
`4`		`- "version": "1.2.0",`
	`4`	`+ "version": "1.2.1",`
`5`	`5`	`"author": "Colten Krauter <coltenkrauter>",`
`6`	`6`	`"type": "module",`
`7`	`7`	`"homepage": "https://buymeacoffee.com/coltenkrauter",`