Skip to content

Commit 2f33a2f

Browse files
authored
PhpdocNoSuperfluousParamFixerTest - handle multiline array shapes (#1066)
1 parent d0bb532 commit 2f33a2f

File tree

3 files changed

+52
-3
lines changed

3 files changed

+52
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# CHANGELOG for PHP CS Fixer: custom fixers
22

3+
## v3.33.0
4+
- Update minimum PHP CS Fixer version to 3.86.0
5+
36
## v3.32.0
47
- Add FunctionParameterSeparationFixer
58
- Update minimum PHP CS Fixer version to 3.85.0

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"php": "^7.4 || ^8.0",
1414
"ext-filter": "*",
1515
"ext-tokenizer": "*",
16-
"friendsofphp/php-cs-fixer": "^3.85"
16+
"friendsofphp/php-cs-fixer": "^3.86"
1717
},
1818
"require-dev": {
1919
"phpunit/phpunit": "^9.6.22 || 10.5.45 || ^11.5.7"

tests/Fixer/PhpdocNoSuperfluousParamFixerTest.php

Lines changed: 48 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ public function __construct(mixed $callback) {}
321321
* @param array{value: string} $param2
322322
* @param ARRAY{value: string} $param3
323323
*/
324-
function foo(array $param1, $param2, ARRAY $param3) {}
324+
function singleLineArrayShapes(array $param1, $param2, ARRAY $param3) {}
325325
PHP,
326326
<<<'PHP'
327327
<?php
@@ -331,7 +331,53 @@ function foo(array $param1, $param2, ARRAY $param3) {}
331331
* @param array{value: string} $param404
332332
* @param ARRAY{value: string} $param3
333333
*/
334-
function foo(array $param1, $param2, ARRAY $param3) {}
334+
function singleLineArrayShapes(array $param1, $param2, ARRAY $param3) {}
335+
PHP,
336+
];
337+
338+
yield [
339+
<<<'PHP'
340+
<?php
341+
/**
342+
*/
343+
function removeMultiLineArrayShapes() {}
344+
PHP,
345+
<<<'PHP'
346+
<?php
347+
/**
348+
* @param array{value: string} $param1
349+
* @param array{
350+
* value: string
351+
* } $param2
352+
* @param array{value: string} $param3
353+
* @param array{
354+
* value1: bool,
355+
* value2: int,
356+
* value3: string,
357+
* } $param4
358+
* @param array{value: string} $param5
359+
*/
360+
function removeMultiLineArrayShapes() {}
361+
PHP,
362+
];
363+
364+
yield [
365+
<<<'PHP'
366+
<?php
367+
/**
368+
* @param array{value: string} $param1
369+
* @param array{
370+
* value: string
371+
* } $param2
372+
* @param array{value: string} $param3
373+
* @param array{
374+
* value1: bool,
375+
* value2: int,
376+
* value3: string,
377+
* } $param4
378+
* @param array{value: string} $param5
379+
*/
380+
function doNotRemoveMultiLineArrayShapes($param1, $param2, $param3, $param4, $param5) {}
335381
PHP,
336382
];
337383
}

0 commit comments

Comments
 (0)