fix PR: 5711 e2e

Author: LiangquanLi930

test/e2e/suites/unmanaged/unmanaged_functional_test.go

@@ -338,7 +338,7 @@ var _ = ginkgo.Context("[unmanaged] [functional]", func() {
 			configCluster.ControlPlaneMachineCount = ptr.To[int64](1)
 			configCluster.WorkerMachineCount = ptr.To[int64](1)
 			configCluster.Flavor = shared.SSMFlavor
-			_, md, _ := createCluster(ctx, configCluster, result)
+			cluster, md, _ := createCluster(ctx, configCluster, result)
 
 			workerMachines := framework.GetMachinesByMachineDeployments(ctx, framework.GetMachinesByMachineDeploymentsInput{
 				Lister:            e2eCtx.Environment.BootstrapClusterProxy.GetClient(),
@@ -360,23 +360,63 @@ var _ = ginkgo.Context("[unmanaged] [functional]", func() {
 			Expect(err).To(BeNil())
 			Expect(len(awsMachineTemplateList.Items)).To(BeNumerically(">", 0), "Expected at least one AWSMachineTemplate")
 
+			ginkgo.By(fmt.Sprintf("Found %d AWSMachineTemplates", len(awsMachineTemplateList.Items)))
+			ginkgo.By(fmt.Sprintf("Cluster: name=%s, namespace=%s, infrastructureRef=%v",
+				cluster.Name, cluster.Namespace, cluster.Spec.InfrastructureRef))
+
+			// Print each AWSMachineTemplate for debugging
+			for i, template := range awsMachineTemplateList.Items {
+				ginkgo.By(fmt.Sprintf("AWSMachineTemplate[%d]: %+v", i, template))
+			}
+
 			foundTemplateWithCapacity := false
 			foundTemplateWithNodeInfo := false
-			for _, template := range awsMachineTemplateList.Items {
+			ginkgo.By(fmt.Sprintf("DEBUG: Found %d AWSMachineTemplates in namespace %s", len(awsMachineTemplateList.Items), namespace.Name))
+			for i, template := range awsMachineTemplateList.Items {
+				ginkgo.By(fmt.Sprintf("DEBUG: Template[%d] - Name: %s", i, template.Name))
+				ginkgo.By(fmt.Sprintf("DEBUG: Template[%d] - Spec.Template.Spec.InstanceType: %s", i, template.Spec.Template.Spec.InstanceType))
+				ginkgo.By(fmt.Sprintf("DEBUG: Template[%d] - Status.Capacity: %v", i, template.Status.Capacity))
+				ginkgo.By(fmt.Sprintf("DEBUG: Template[%d] - Status.NodeInfo: %+v", i, template.Status.NodeInfo))
+				ginkgo.By(fmt.Sprintf("DEBUG: Template[%d] - Status.Conditions: %+v", i, template.Status.Conditions))
+
 				if len(template.Status.Capacity) > 0 {
 					foundTemplateWithCapacity = true
 					ginkgo.By(fmt.Sprintf("AWSMachineTemplate %s has capacity populated: %v", template.Name, template.Status.Capacity))
 					Expect(template.Status.Capacity).To(HaveKey(corev1.ResourceCPU), "Expected CPU to be set in capacity")
 					Expect(template.Status.Capacity).To(HaveKey(corev1.ResourceMemory), "Expected Memory to be set in capacity")
+				} else {
+					ginkgo.By(fmt.Sprintf("WARNING: Template %s has NO capacity populated", template.Name))
 				}
 				if template.Status.NodeInfo != nil {
 					foundTemplateWithNodeInfo = true
 					ginkgo.By(fmt.Sprintf("AWSMachineTemplate %s has nodeInfo populated: %v", template.Name, template.Status.NodeInfo))
 					// Verify architecture is set (should be either amd64 or arm64 for AWS)
-					Expect(template.Status.NodeInfo.Architecture).ToNot(BeEmpty(), "Expected architecture to be set in nodeInfo")
-					Expect(string(template.Status.NodeInfo.Architecture)).To(MatchRegexp("^(amd64|arm64)$"), "Expected architecture to be amd64 or arm64")
-					// Verify operating system is set
-					Expect(template.Status.NodeInfo.OperatingSystem).ToNot(BeEmpty(), "Expected operatingSystem to be set in nodeInfo")
+					ginkgo.By(fmt.Sprintf("DEBUG: Template %s - NodeInfo.Architecture: '%s' (len: %d)", template.Name, template.Status.NodeInfo.Architecture, len(template.Status.NodeInfo.Architecture)))
+					ginkgo.By(fmt.Sprintf("DEBUG: Template %s - NodeInfo.OperatingSystem: '%s' (len: %d)", template.Name, template.Status.NodeInfo.OperatingSystem, len(template.Status.NodeInfo.OperatingSystem)))
+
+					// Verify architecture is set (should be either amd64 or arm64 for AWS)
+					if len(template.Status.NodeInfo.Architecture) == 0 {
+						ginkgo.By(fmt.Sprintf("ERROR: Template %s has empty Architecture field in NodeInfo", template.Name))
+					}
+					Expect(template.Status.NodeInfo.Architecture).ToNot(BeEmpty(), fmt.Sprintf("Expected architecture to be set in nodeInfo for template %s", template.Name))
+					Expect(string(template.Status.NodeInfo.Architecture)).To(MatchRegexp("^(amd64|arm64)$"), fmt.Sprintf("Expected architecture to be amd64 or arm64 for template %s", template.Name))
+					// Verify operating system is set (if available)
+					// Note: OperatingSystem may be empty when:
+					// 1. No explicit AMI ID is specified
+					// 2. Kubernetes version cannot be determined (MachineDeployment not yet created)
+					// 3. AMI lookup fails
+					// In these cases, the controller falls back to instance type architecture only.
+					// See: controllers/awsmachinetemplate_controller.go:319-323 (Strategy 3)
+					if len(template.Status.NodeInfo.OperatingSystem) == 0 {
+						ginkgo.By(fmt.Sprintf("INFO: Template %s has empty OperatingSystem (this is acceptable in fallback scenarios)", template.Name))
+						ginkgo.By(fmt.Sprintf("DEBUG: Template %s full status: %+v", template.Name, template.Status))
+					} else {
+						ginkgo.By(fmt.Sprintf("INFO: Template %s has OperatingSystem set to: %s", template.Name, template.Status.NodeInfo.OperatingSystem))
+						// If OperatingSystem is set, verify it's a valid value
+						Expect(string(template.Status.NodeInfo.OperatingSystem)).To(MatchRegexp("^(linux|windows)$"), fmt.Sprintf("Expected operatingSystem to be linux or windows for template %s", template.Name))
+					}
+				} else {
+					ginkgo.By(fmt.Sprintf("WARNING: Template %s has NodeInfo == nil", template.Name))
 				}
 			}
 			Expect(foundTemplateWithCapacity).To(BeTrue(), "Expected at least one AWSMachineTemplate to have capacity populated")