Skip to content

Commit b167235

Browse files
authored
Merge pull request #8201 from jlamillan/jlamillan/404-is-not-success
OCI provider: Avoid interpreting HTTP 404 as success on delete
2 parents dd40212 + af73650 commit b167235

File tree

1 file changed

+1
-3
lines changed
  • cluster-autoscaler/cloudprovider/oci/nodepools

1 file changed

+1
-3
lines changed

cluster-autoscaler/cloudprovider/oci/nodepools/cache.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ func (c *nodePoolCache) removeInstance(nodePoolID, instanceID string, nodeName s
9898
statusSuccess := statusCode >= 200 && statusCode < 300
9999
success = statusSuccess ||
100100
// 409 means the instance is already going to be processed for deletion
101-
statusCode == http.StatusConflict ||
102-
// 404 means it is probably already deleted and our cache may be stale
103-
statusCode == http.StatusNotFound
101+
statusCode == http.StatusConflict
104102
if !success {
105103
status := httpResp.Status
106104
klog.Infof("Received error status %s while deleting node %q", status, instanceID)

0 commit comments

Comments
 (0)