Skip to content

Commit 37c682e

Browse files
committed
Add updates on e2e test as discussed in PR#5346
Signed-off-by: Swati Gupta <swatig@nvidia.com>
1 parent 69ffb96 commit 37c682e

File tree

1 file changed

+16
-1
lines changed
  • keps/sig-node/3695-pod-resources-for-dra

1 file changed

+16
-1
lines changed

keps/sig-node/3695-pod-resources-for-dra/README.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,12 @@ These cases will be added in the existing e2e tests:
265265
- Get API work with DRA and device plugin.
266266
- List API work with DRA and Device plugin.
267267

268+
[Get](https://github.com/kubernetes/kubernetes/pull/116846): [sig-node-kubelet](https://testgrid.k8s.io/sig-node-kubelet?include-filter-by-regex=PodResources), [triage](https://storage.googleapis.com/k8s-triage/index.html?test=PodResources)
269+
270+
Other improvements are addressed in:
271+
- https://github.com/kubernetes/kubernetes/pull/132028
272+
- https://github.com/kubernetes/kubernetes/pull/132345
273+
268274
### Graduation Criteria
269275

270276
#### Alpha
@@ -282,6 +288,13 @@ These cases will be added in the existing e2e tests:
282288

283289
- [ ] Allowing time for feedback (1 year).
284290
- [ ] Risks have been addressed.
291+
- [ ] Add explicit feature enablement/disablement tests, before the feature is turned on by default.
292+
- [ ] Additional test cases are needed to verify Get() behavior in diverse scenarios
293+
- Pods with multiple containers.
294+
- Pods that do not use any exclusive resources.
295+
- Comparison of List() and Get() on returned pods to validate consistency.
296+
- Pod exists but container name is invalid
297+
- Get() is called on terminated pods to validate appropriate error handling.
285298

286299
### Upgrade / Downgrade Strategy
287300

@@ -334,7 +347,9 @@ The API becomes available again. The API is stateless, so no recovery is needed,
334347

335348
###### Are there any tests for feature enablement/disablement?
336349

337-
e2e test will demonstrate that when the feature gate is disabled, the API returns the appropriate error code. (https://github.com/kubernetes/kubernetes/pull/116846)
350+
This e2e test (https://github.com/kubernetes/kubernetes/pull/116846) will demonstrate that when the feature gate is disabled, the API returns the appropriate error code. The explicit on/off tests are scattered across the existing tests:
351+
- https://github.com/kubernetes/kubernetes/blob/v1.34.0-alpha.1/test/e2e_node/podresources_test.go#L977
352+
- https://github.com/kubernetes/kubernetes/blob/v1.34.0-alpha.1/test/e2e_node/podresources_test.go#L1066
338353

339354
### Rollout, Upgrade and Rollback Planning
340355

0 commit comments

Comments
 (0)