Skip to content

Commit 562b8fe

Browse files
committed
Promote MAP to beta in 1.34
1 parent 61abddc commit 562b8fe

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 3962
22
alpha:
33
approver: "@deads2k"
4+
beta:
5+
approver: "@deads2k"

keps/sig-api-machinery/3962-mutating-admission-policies/README.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,15 +1032,16 @@ We will test the edge cases mostly in integration test and unit test. We may add
10321032

10331033
#### Beta
10341034

1035-
- Gather feedback from developers and surveys
1036-
- Complete features A, B, C
1035+
- Have proper monitoring for MAP admission plugin
1036+
- Fix any blocking issues/bugs surfaced before code freeze
10371037
- Additional tests are in Testgrid and linked in KEP
1038+
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
1039+
- Including all function needed with performance and security in consideration
10381040

10391041
#### GA
10401042

10411043
- N examples of real-world usage
10421044
- N installs
1043-
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
10441045
- Allowing time for feedback
10451046

10461047
**Note:** Generally we also wait at least two releases between beta and
@@ -1296,7 +1297,16 @@ Describe manual testing that was done and the outcomes.
12961297
Longer term, we may want to require automated upgrade/rollback tests, but we
12971298
are missing a bunch of machinery and tooling and can't do that now.
12981299
-->
1299-
Upgrade and rollback will be tested before the feature goes to Beta.
1300+
Upgrade and rollback will be tested manually in a kind:
1301+
1302+
- Enabled feature gate, created a MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding with mutation to add a label to a pod.
1303+
1304+
- Disabled feature gate, restarted apiserver, confirmed that the
1305+
MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding still exist. Added another Pod
1306+
to verify that the mutation would not happen.
1307+
1308+
- Re-enabled the feature gate, restarted apiserver, confirmed that
1309+
the mutation will occur for new incoming pod creation request.
13001310

13011311
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
13021312

@@ -1376,7 +1386,7 @@ Pick one more of these and delete the rest.
13761386
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
13771387
implementation difficulties, etc.).
13781388
-->
1379-
No. We are open to input.
1389+
No.
13801390

13811391
### Dependencies
13821392

@@ -1511,6 +1521,7 @@ details). For now, we leave it here.
15111521
-->
15121522

15131523
###### How does this feature react if the API server and/or etcd is unavailable?
1524+
No change from existing behavior. The feature will serve same as if it's disabled.
15141525

15151526
###### What are other known failure modes?
15161527

keps/sig-api-machinery/3962-mutating-admission-policies/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,17 @@ see-also:
2323
- "/keps/sig-bbb/2345-everyone-gets-a-kep"
2424

2525
# The target maturity stage in the current dev cycle for this KEP.
26-
stage: alpha
26+
stage: beta
2727

2828
# The most recent milestone for which work toward delivery of this KEP has been
2929
# done. This can be the current (upcoming) milestone, if it is being actively
3030
# worked on.
31-
latest-milestone: "v1.32"
31+
latest-milestone: "v1.34"
3232

3333
# The milestone at which this feature was, or is targeted to be, at each stage.
3434
milestone:
3535
alpha: "v1.32"
36+
beta: "v1.34"
3637

3738
# The following PRR answers are required at alpha release
3839
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)