Skip to content

Commit e68fa5b

Browse files
committed
KEP 1645: add ServiceImport conditions
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
1 parent 63d4f6f commit e68fa5b

File tree

1 file changed

+17
-0
lines changed
  • keps/sig-multicluster/1645-multi-cluster-services-api

1 file changed

+17
-0
lines changed

keps/sig-multicluster/1645-multi-cluster-services-api/README.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,11 @@ cluster, non-cluster-admin users should not be allowed to create or modify
538538
`ServiceImport` resources. The mcs-controller should be solely responsible for
539539
the lifecycle of a `ServiceImport`.
540540

541+
Some error may occurs during the `ServiceImport`'s lifecycle, such as IP protocol
542+
incompatibilities (i.e.: importing an IPv6 only service in an IPv4 cluster). These
543+
errors and general status reporting of a `ServiceImport` should be reported
544+
via its status conditions fields.
545+
541546
For each exported service, one `ServiceExport` will exist in each cluster that
542547
exports the service. The mcs-controller will create and maintain a derived
543548
`ServiceImport` in each cluster within the clusterset so long as the service's
@@ -620,6 +625,12 @@ type ServiceImportStatus struct {
620625
// +listType=map
621626
// +listMapKey=cluster
622627
Clusters []ClusterStatus `json:"clusters"`
628+
// +optional
629+
// +patchStrategy=merge
630+
// +patchMergeKey=type
631+
// +listType=map
632+
// +listMapKey=type
633+
Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`
623634
}
624635

625636
// ClusterStatus contains service configuration mapped to a specific source cluster
@@ -644,6 +655,12 @@ spec:
644655
port: 80
645656
sessionAffinity: None
646657
status:
658+
status:
659+
conditions:
660+
- type: Ready
661+
reason: Ready
662+
status: "True"
663+
lastTransitionTime: "2020-03-30T01:33:51Z"
647664
clusters:
648665
- cluster: us-west2-a-my-cluster
649666
```

0 commit comments

Comments
 (0)