Skip to content

Commit 71b908f

Browse files
SoumyaRaikwarSoumyaRaikwar
committed
Fix topology spread constraint implementation and tests
- Fix formatting issues in deployment.go - Update deployment_test.go with proper topology spread constraint tests - Add missing deletion timestamp metric documentation - Fix deployment status condition reason labels in tests - Ensure all tests pass with proper metric values
1 parent 9f42507 commit 71b908f

File tree

3 files changed

+387
-900
lines changed

3 files changed

+387
-900
lines changed

‎docs/metrics/workload/deployment-metrics.md‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22

33
| Metric name | Metric type | Description | Labels/tags | Status |
44
| ----------------------------------------------------------- | ----------- | --------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------ |
5-
| kube_deployment_annotations | Gauge | Kubernetes annotations converted to Prometheus labels controlled via [--metric-annotations-allowlist](../../developer/cli-arguments.md) | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> <br> `annotation_DEPLOYMENT_ANNOTATION`=<DEPLOYMENT_ANNOTATION> | EXPERIMENTAL |
6-
| kube_deployment_status_replicas | Gauge | The number of replicas per deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
7-
| kube_deployment_status_replicas_ready | Gauge | The number of ready replicas per deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
8-
| kube_deployment_status_replicas_available | Gauge | The number of available replicas per deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
9-
| kube_deployment_status_replicas_unavailable | Gauge | The number of unavailable replicas per deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
10-
| kube_deployment_status_replicas_updated | Gauge | The number of updated replicas per deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
11-
| kube_deployment_status_observed_generation | Gauge | The generation observed by the deployment controller | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
12-
| kube_deployment_status_condition | Gauge | The current status conditions of a deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> <br> `reason`=<deployment-transition-reason> <br> `condition`=<deployment-condition> <br> `status`=<true\|false\|unknown> | STABLE |
13-
| kube_deployment_spec_replicas | Gauge | Number of desired pods for a deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
14-
| kube_deployment_spec_paused | Gauge | Whether the deployment is paused and will not be processed by the deployment controller | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
15-
| kube_deployment_spec_strategy_rollingupdate_max_unavailable | Gauge | Maximum number of unavailable replicas during a rolling update of a deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
16-
| kube_deployment_spec_strategy_rollingupdate_max_surge | Gauge | Maximum number of replicas that can be scheduled above the desired number of replicas during a rolling update of a deployment | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
17-
| kube_deployment_spec_topology_spread_constraint | Gauge | Explicit details of each topology spread constraint in the deployment's pod template | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> <br> `topology_key`=<topology-key> <br> `max_skew`=<max-skew-value> <br> `when_unsatisfiable`=<DoNotSchedule\|ScheduleAnyway> <br> `min_domains`=<min-domains-value> <br> `label_selector`=<label-selector-string> | ALPHA |
18-
| kube_deployment_metadata_generation | Gauge | Sequence number representing a specific generation of the desired state | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
19-
| kube_deployment_labels | Gauge | Kubernetes labels converted to Prometheus labels controlled via [--metric-labels-allowlist](../../developer/cli-arguments.md) | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> <br> `label_DEPLOYMENT_LABEL`=<DEPLOYMENT_LABEL> | STABLE |
20-
| kube_deployment_created | Gauge | Unix creation timestamp | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | STABLE |
21-
| kube_deployment_deletion_timestamp | Gauge | Unix deletion timestamp | `deployment`=<deployment-name> <br> `namespace`=<deployment-namespace> | EXPERIMENTAL |
5+
| kube_deployment_annotations | Gauge | Kubernetes annotations converted to Prometheus labels controlled via [--metric-annotations-allowlist](../../developer/cli-arguments.md) | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; <br> `annotation_DEPLOYMENT_ANNOTATION`=&lt;DEPLOYMENT_ANNOTATION&gt; | EXPERIMENTAL |
6+
| kube_deployment_status_replicas | Gauge | The number of replicas per deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
7+
| kube_deployment_status_replicas_ready | Gauge | The number of ready replicas per deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
8+
| kube_deployment_status_replicas_available | Gauge | The number of available replicas per deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
9+
| kube_deployment_status_replicas_unavailable | Gauge | The number of unavailable replicas per deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
10+
| kube_deployment_status_replicas_updated | Gauge | The number of updated replicas per deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
11+
| kube_deployment_status_observed_generation | Gauge | The generation observed by the deployment controller | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
12+
| kube_deployment_status_condition | Gauge | The current status conditions of a deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; <br> `reason`=&lt;deployment-transition-reason&gt; <br> `condition`=&lt;deployment-condition&gt; <br> `status`=&lt;true\|false\|unknown&gt; | STABLE |
13+
| kube_deployment_spec_replicas | Gauge | Number of desired pods for a deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
14+
| kube_deployment_spec_paused | Gauge | Whether the deployment is paused and will not be processed by the deployment controller | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
15+
| kube_deployment_spec_strategy_rollingupdate_max_unavailable | Gauge | Maximum number of unavailable replicas during a rolling update of a deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
16+
| kube_deployment_spec_strategy_rollingupdate_max_surge | Gauge | Maximum number of replicas that can be scheduled above the desired number of replicas during a rolling update of a deployment | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
17+
| kube_deployment_spec_topology_spread_constraint | Gauge | Explicit details of each topology spread constraint in the deployment's pod template | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; <br> `topology_key`=&lt;topology-key&gt; <br> `max_skew`=&lt;max-skew-value&gt; <br> `when_unsatisfiable`=&lt;DoNotSchedule\|ScheduleAnyway&gt; <br> `min_domains`=&lt;min-domains-value&gt; <br> `label_selector`=&lt;label-selector-string&gt; | ALPHA |
18+
| kube_deployment_metadata_generation | Gauge | Sequence number representing a specific generation of the desired state | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
19+
| kube_deployment_labels | Gauge | Kubernetes labels converted to Prometheus labels controlled via [--metric-labels-allowlist](../../developer/cli-arguments.md) | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; <br> `label_DEPLOYMENT_LABEL`=&lt;DEPLOYMENT_LABEL&gt; | STABLE |
20+
| kube_deployment_created | Gauge | Unix creation timestamp | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | STABLE |
21+
| kube_deployment_deletion_timestamp | Gauge | Unix deletion timestamp | `deployment`=&lt;deployment-name&gt; <br> `namespace`=&lt;deployment-namespace&gt; | EXPERIMENTAL |

0 commit comments

Comments
 (0)