fixing empty reasons and adding tests

Author: Rishab87

internal/store/deployment.go

@@ -183,8 +183,10 @@ func deploymentMetricFamilies(allowAnnotationsList, allowLabelsList []string) []
 						metric := m
 
 						reason := c.Reason
-						if _, ok := allowedDeploymentReasons[reason]; !ok {
-							reason = "unknown"
+						if reason != "" {
+							if _, ok := allowedDeploymentReasons[reason]; !ok {
+								reason = "unknown"
+							}
 						}
 
 						metric.LabelKeys = []string{"reason", "condition", "status"}

internal/store/deployment_test.go

@@ -215,15 +215,16 @@ func TestDeploymentStore(t *testing.T) {
 		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="unknown",condition="Available",status="true"} 0
 		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="unknown",condition="Available",status="false"} 1
 		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="unknown",condition="Available",status="unknown"} 0
-		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="unknown",condition="Progressing",status="true"} 1
-		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="unknown",condition="Progressing",status="false"} 0
-		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="unknown",condition="Progressing",status="unknown"} 0
+		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="",condition="Progressing",status="true"} 1
+		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="",condition="Progressing",status="false"} 0
+		kube_deployment_status_condition{deployment="depl3",namespace="ns3",reason="",condition="Progressing",status="unknown"} 0
 		kube_deployment_status_observed_generation{deployment="depl3",namespace="ns3"} 0
+		kube_deployment_status_replicas{deployment="depl3",namespace="ns3"} 0
 		kube_deployment_status_replicas_available{deployment="depl3",namespace="ns3"} 0
 		kube_deployment_status_replicas_ready{deployment="depl3",namespace="ns3"} 0
 		kube_deployment_status_replicas_unavailable{deployment="depl3",namespace="ns3"} 0
 		kube_deployment_status_replicas_updated{deployment="depl3",namespace="ns3"} 0
-		kube_deployment_status_replicas{deployment="depl3",namespace="ns3"} 0`,
+`,
 		},
 	}