Skip to content

Commit eab3c5d

Browse files
authored
Merge pull request #35138 from pohly/dra-e2e
DRA: invoke upgrade/downgrade as e2e_dra
2 parents 71bd2b0 + cdd3d1d commit eab3c5d

File tree

2 files changed

+19
-8
lines changed

2 files changed

+19
-8
lines changed

config/jobs/kubernetes/sig-node/dra-canary.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -499,10 +499,15 @@ presubmits:
499499
- /bin/bash
500500
- -xce
501501
- |
502-
make WHAT="cmd/kube-apiserver cmd/kube-scheduler cmd/kube-controller-manager cmd/kube-proxy cmd/kubelet"
503-
# "Normal" integration tests under test/integration/dra run in pull-kubernetes-integration.
504-
# The "more complex" ones with a dependency on local-up-cluster.sh are under test/integration/dra/cluster, in a separate Ginkgo suite.
505-
make test WHAT="test/integration/dra/cluster" FULL_LOG=true KUBETEST_IN_DOCKER=true KUBERNETES_SERVER_BIN_DIR="$(pwd)/_output/local/bin/linux/amd64" KUBERNETES_SERVER_CACHE_DIR=/tmp/cache-dir KUBE_TIMEOUT=-timeout=30m KUBE_TEST_ARGS="-args -ginkgo.junit-report=${ARTIFACTS}/junit.xml"
502+
# test/e2e_dra is a separate Ginkgo suite with a dependency on local-up-cluster.sh.
503+
# We could use "make test WHAT=./test/e2e_dra", but then we would get a test JUnit file
504+
# in addition to the better one from Ginkgo, so instead we build the test binary and
505+
# invoke it directly. The Ginkgo CLI doesn't add any benefit because we cannot run
506+
# tests in parallel.
507+
#
508+
# We also need the control plane binaries.
509+
make WHAT="./test/e2e_dra/e2e_dra.test cmd/kube-apiserver cmd/kube-scheduler cmd/kube-controller-manager cmd/kube-proxy cmd/kubelet"
510+
KUBETEST_IN_DOCKER=true CONTAINER_RUNTIME_ENDPOINT=/var/run/docker/containerd/containerd.sock KUBERNETES_SERVER_BIN_DIR="$(pwd)/_output/local/bin/linux/amd64" KUBERNETES_SERVER_CACHE_DIR=/tmp/cache-dir -ginkgo.timeout=30m -ginkgo.junit-report=${ARTIFACTS}/junit.xml -ginkgo.v -test.v
506511
# docker-in-docker needs privileged mode
507512
securityContext:
508513
privileged: true

config/jobs/kubernetes/sig-node/dra.jinja

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,16 @@ presubmits:
117117
- /bin/bash
118118
- -xce
119119
- |
120-
make WHAT="cmd/kube-apiserver cmd/kube-scheduler cmd/kube-controller-manager cmd/kube-proxy cmd/kubelet"
121-
# "Normal" integration tests under test/integration/dra run in pull-kubernetes-integration.
122-
# The "more complex" ones with a dependency on local-up-cluster.sh are under test/integration/dra/cluster, in a separate Ginkgo suite.
123-
make test WHAT="test/integration/dra/cluster" FULL_LOG=true KUBETEST_IN_DOCKER=true KUBERNETES_SERVER_BIN_DIR="$(pwd)/_output/local/bin/linux/amd64" KUBERNETES_SERVER_CACHE_DIR=/tmp/cache-dir KUBE_TIMEOUT=-timeout=30m KUBE_TEST_ARGS="-args -ginkgo.junit-report=${ARTIFACTS}/junit.xml"
120+
# test/e2e_dra is a separate Ginkgo suite with a dependency on local-up-cluster.sh.
121+
# We could use "make test WHAT=./test/e2e_dra", but then we would get a test JUnit file
122+
# in addition to the better one from Ginkgo, so instead we build the test binary and
123+
# invoke it directly. The Ginkgo CLI doesn't add any benefit because we cannot run
124+
# tests in parallel.
125+
#
126+
# We also need the control plane binaries.
127+
make WHAT="./test/e2e_dra/e2e_dra.test cmd/kube-apiserver cmd/kube-scheduler cmd/kube-controller-manager cmd/kube-proxy cmd/kubelet"
128+
KUBETEST_IN_DOCKER=true CONTAINER_RUNTIME_ENDPOINT=/var/run/docker/containerd/containerd.sock KUBERNETES_SERVER_BIN_DIR="$(pwd)/_output/local/bin/linux/amd64" KUBERNETES_SERVER_CACHE_DIR=/tmp/cache-dir -ginkgo.timeout=30m -ginkgo.junit-report=${ARTIFACTS}/junit.xml -ginkgo.v -test.v
129+
124130
{%- elif job_type == "e2e" %}
125131
args:
126132
- /bin/bash

0 commit comments

Comments
 (0)