Skip to content

Commit 600db58

Browse files
committed
fixed interface pybind bugs
1 parent ed76b8b commit 600db58

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

mooncake-integration/transfer_engine/transfer_engine_py.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -678,8 +678,7 @@ void bind_coro_rpc_interface(py::module_ &m) {
678678
.def("initialize_client", &CoroRPCInterface::initializeClient,
679679
"pool_size"_a = 10, "timeout_seconds"_a = 30)
680680
.def("initialize_server", &CoroRPCInterface::initializeServer,
681-
"listen_address"_a, "thread_count"_a = 8,
682-
"timeout_seconds"_a = 30, "pool_size"_a = 4)
681+
"listen_address"_a, "thread_count"_a = 8, "timeout_seconds"_a = 30)
683682
.def("start_server", &CoroRPCInterface::startServer)
684683
.def("start_server_async", &CoroRPCInterface::startServerAsync)
685684
.def("stop_server", &CoroRPCInterface::stopServer)

mooncake-transfer-engine/include/transport/coro_rpc_connector/cororpc_interface.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ class CoroRPCInterface {
4949

5050
// Convenience methods for common use cases
5151
bool initializeClient(size_t pool_size = 10, size_t timeout_seconds = 30);
52-
bool initializeServer(const std::string& listen_address,
53-
size_t thread_count = 8, size_t timeout_seconds = 30);
52+
bool initializeServer(const std::string& listen_address,
53+
size_t thread_count = 8, size_t timeout_seconds = 30);
5454

5555
bool startServer();
5656
bool startServerAsync();

mooncake-transfer-engine/src/transport/coro_rpc_connector/cororpc_interface.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,15 @@ bool CoroRPCInterface::initialize(const std::string& local_address,
3939
}
4040

4141
// Convenience method for client initialization
42-
bool CoroRPCInterface::initializeClient(size_t pool_size, size_t timeout_seconds) {
42+
bool CoroRPCInterface::initializeClient(size_t pool_size,
43+
size_t timeout_seconds) {
4344
return initialize("", 0, timeout_seconds, pool_size);
4445
}
4546

46-
// Convenience method for server initialization
47+
// Convenience method for server initialization
4748
bool CoroRPCInterface::initializeServer(const std::string& listen_address,
48-
size_t thread_count, size_t timeout_seconds) {
49+
size_t thread_count,
50+
size_t timeout_seconds) {
4951
return initialize(listen_address, thread_count, timeout_seconds, 4);
5052
}
5153

0 commit comments

Comments
 (0)