- Custom game actions can now be edited.

- Added additional profile options to Profile menu bar.
- Fixed issue where incorrect game action was deleted when deleting an action.
- Fixed issue where game actions were not being run from game binary directory.
- Fixed game title ellipsis not working in profile selection dropdown.
- All log messages now show up in GUI log.
- Updated README.

Author: lVlyke

README.md

@@ -131,6 +131,8 @@ You can choose to override any of the profile paths to point to other directorie
 
 By default, profiles are stored in the `profiles` directory of Starfield Mod Loader. Overriding this path will allow you to store the profile at an alternative location. This can be useful if your game is installed on a different drive and you want to co-locate the profile to the same drive as the game to enable Link mode.
 
+A profile with an overridden root path is called an **external profile**. Existing external profiles can also be added or imported by selecting **Profiles -> Add External Profile** or **Profiles -> Import Profile**.
+
 #### Profile mods path
 
 Overriding this path will allow you to store the profile's mods at an alternative location.

src/app/models/app-message.ts

@@ -153,7 +153,7 @@ export namespace AppMessage {
     }
 
     export interface CopyProfileData extends Base {
-        id: `${Prefix}:copyProfileData`;
+        id: `${Prefix}:copyProfile`;
         data: {
             srcProfile: AppProfile;
             destProfile: AppProfile;
@@ -614,7 +614,7 @@ export namespace AppMessage {
         "app:loadProfile",
         "app:loadExternalProfile",
         "app:saveProfile",
-        "app:copyProfileData",
+        "app:copyProfile",
         "app:verifyProfile",
         "app:showPreferences",
         "app:loadGameDatabase",

src/app/pages/mods-overview/mods-overview.page.html

@@ -413,6 +413,7 @@
     </div>
 }
 
+<!-- Log panel -->
 <div id="log-pane" class="mat-app-background" [attr.log-panel-active]="isLogPanelEnabled">
     <app-log />
 </div>
@@ -472,7 +473,7 @@
                 </button>
 
                 <button mat-list-item (click)="exportActiveProfile(); showProfileMgmtMenuRef?.close()">
-                    <mat-icon matListIcon color="primary">person_remove</mat-icon>
+                    <mat-icon matListIcon color="accent">person_remove</mat-icon>
                     <span matLine>Export Profile</span>
                 </button>
 
@@ -552,13 +553,20 @@
                 @let gameActions = [profileManager.LAUNCH_GAME_ACTION].concat(activeProfile!.customGameActions ?? []);
 
                 @for (gameAction of gameActions; track $index) {
-                    <button mat-list-item (click)="profileManager.setActiveGameAction(gameAction); gameActionsMenuRef?.close()">
+                    <button mat-list-item class="game-action" (click)="profileManager.setActiveGameAction(gameAction); gameActionsMenuRef?.close()">
                         <mat-icon matListIcon color="accent">play_circle</mat-icon>
 
                         <span class="game-action-name">{{ gameAction.name }}</span>
 
                         @if ($index > 0) {
                             <button mat-icon-button
+                                    matTooltip="Edit"
+                                    (click)="editCustomGameActionByIndex($index - 1, gameAction); gameActionsMenuRef?.close(); $event.stopPropagation()">
+                                <mat-icon color="primary">edit</mat-icon>
+                            </button>
+
+                            <button mat-icon-button
+                                    matTooltip="Delete"
                                     (click)="removeCustomGameActionByIndex($index - 1); gameActionsMenuRef?.close(); $event.stopPropagation()">
                                 <mat-icon color="warn">delete</mat-icon>
                             </button>

src/app/pages/mods-overview/mods-overview.page.scss

@@ -346,6 +346,8 @@
                     &#game-action-button {
                         border-top-right-radius: 0;
                         border-bottom-right-radius: 0;
+                        max-width: 30rem;
+                        overflow: hidden;
                     }
 
                     &#game-action-menu-button {
@@ -429,6 +431,16 @@
         text-overflow: ellipsis;
         text-wrap: nowrap;
         overflow: hidden;
+        display: inline-block;
+        vertical-align: middle;
+        align-content: center;
+    }
+
+    @at-root .game-actions-popup {
+
+        mat-card-content, mat-action-list {
+            padding: 0;
+        }
     }
 }
 
@@ -444,8 +456,12 @@
     }
 }
 
-.game-action-name {
+.game-action {
     @at-root .game-actions-popup &, :host & {
-        flex-grow: 1;
+
+        .game-action-name {
+            flex-grow: 1;
+            margin-right: 1rem;
+        }
     }
 }

src/app/pages/mods-overview/mods-overview.page.ts

@@ -20,6 +20,7 @@ import { AppDialogs } from "../../services/app-dialogs";
 import { ActiveProfileState } from "../../state/active-profile/active-profile.state";
 import { GamePluginProfileRef } from "../../models/game-plugin-profile-ref";
 import { LangUtils } from "../../util/lang-utils";
+import { GameAction } from "../../models/game-action";
 
 @Component({
     selector: "app-mods-overview-page",
@@ -306,21 +307,11 @@ export class AppModsOverviewPage extends BasePage {
     }
 
     protected exportActiveProfile(): void {
-        this.dialogs.showDefault("Are you sure you want to export this profile?", [
-            DialogManager.YES_ACTION,
-            DialogManager.NO_ACTION_PRIMARY
-        ]).pipe(
-            filterTrue()
-        ).subscribe(() => this.profileManager.exportProfile(this.activeProfile!));
+        this.profileManager.exportProfileFromUser(this.activeProfile!);
     }
 
     protected deleteActiveProfile(): void {
-        this.dialogs.showDefault("Are you sure you want to delete this profile?", [
-            DialogManager.YES_ACTION,
-            DialogManager.NO_ACTION_PRIMARY
-        ]).pipe(
-            filterTrue()
-        ).subscribe(() => this.profileManager.deleteProfile(this.activeProfile!));
+        this.profileManager.deleteProfileFromUser(this.activeProfile!);
     }
 
     protected addCustomGameAction(): void {
@@ -329,13 +320,19 @@ export class AppModsOverviewPage extends BasePage {
         ).subscribe(gameAction => this.profileManager.addCustomGameAction(gameAction));
     }
 
+    protected editCustomGameActionByIndex(index: number, gameAction: GameAction): void {
+        this.dialogs.showAddCustomGameActionDialog({ ...gameAction }).pipe(
+            filterDefined()
+        ).subscribe(gameAction => this.profileManager.editCustomGameActionByIndex(index, gameAction));
+    }
+
     protected removeCustomGameActionByIndex(index: number): void {
         this.dialogs.showDefault("Are you sure you want to delete this action?", [
             DialogManager.YES_ACTION,
             DialogManager.NO_ACTION_PRIMARY
         ]).pipe(
             filterTrue()
-        ).subscribe(() => this.profileManager.removeCustomGameActionByIndex(index - 1));
+        ).subscribe(() => this.profileManager.removeCustomGameActionByIndex(index));
     }
 
     protected resolveBackupName(backupEntry: AppProfile.PluginBackupEntry): string {

src/app/services/profile-manager.ts

@@ -92,6 +92,33 @@ export class ProfileManager {
             ))
         ).subscribe();
 
+        messageHandler.messages$.pipe(
+            filter(message => message.id === "app:copyProfile"),
+            withLatestFrom(this.activeProfile$),
+            filter(([, activeProfile]) => !!activeProfile),
+            switchMap(([, activeProfile]) => this.copyProfileFromUser(activeProfile!).pipe(
+                catchError((err) => (log.error("Failed to copy profile: ", err), EMPTY))
+            ))
+        ).subscribe();
+
+        messageHandler.messages$.pipe(
+            filter(message => message.id === "app:exportProfile"),
+            withLatestFrom(this.activeProfile$),
+            filter(([, activeProfile]) => !!activeProfile),
+            switchMap(([, activeProfile]) => this.exportProfileFromUser(activeProfile!).pipe(
+                catchError((err) => (log.error("Failed to export profile: ", err), EMPTY))
+            ))
+        ).subscribe();
+
+        messageHandler.messages$.pipe(
+            filter(message => message.id === "app:deleteProfile"),
+            withLatestFrom(this.activeProfile$),
+            filter(([, activeProfile]) => !!activeProfile),
+            switchMap(([, activeProfile]) => this.deleteProfileFromUser(activeProfile!).pipe(
+                catchError((err) => (log.error("Failed to delete profile: ", err), EMPTY))
+            ))
+        ).subscribe();
+
         messageHandler.messages$.pipe(
             filter((message): message is AppMessage.BeginModAdd => message.id === "profile:beginModAdd"),
             withLatestFrom(this.activeProfile$),
@@ -533,6 +560,16 @@ export class ProfileManager {
         ));
     }
 
+    public exportProfileFromUser(profile: AppProfile): Observable<any> {
+        return runOnce(this.dialogs.showDefault("Are you sure you want to export this profile?", [
+            DialogManager.YES_ACTION,
+            DialogManager.NO_ACTION_PRIMARY
+        ]).pipe(
+            filterTrue(),
+            switchMap(() => this.exportProfile(profile))
+        ));
+    }
+
     public deleteProfile(profile: AppProfile): Observable<any> {
         const loadingIndicator = this.appManager.showLoadingIndicator("Deleting Profile...");
 
@@ -542,6 +579,16 @@ export class ProfileManager {
         ));
     }
 
+    public deleteProfileFromUser(profile: AppProfile): Observable<any> {
+        return runOnce(this.dialogs.showDefault("Are you sure you want to delete this profile?", [
+            DialogManager.YES_ACTION,
+            DialogManager.NO_ACTION_PRIMARY
+        ]).pipe(
+            filterTrue(),
+            switchMap(() => this.deleteProfile(profile))
+        ));
+    }
+
     public importProfileFromUser(directImport: boolean = false): Observable<AppProfile | undefined> {
         // Load the external profile
         return runOnce(ElectronUtils.invoke("app:loadExternalProfile", {}).pipe(
@@ -585,7 +632,7 @@ export class ProfileManager {
                     if (profileToCopy.name !== newProfile.rootPathOverride) {
                         const loadingIndicator = this.appManager.showLoadingIndicator("Copying Profile...");
 
-                        return ElectronUtils.invoke("app:copyProfileData", {
+                        return ElectronUtils.invoke("app:copyProfile", {
                             srcProfile: profileToCopy,
                             destProfile: newProfile
                         }).pipe(
@@ -1028,6 +1075,10 @@ export class ProfileManager {
         return this.store.dispatch(new ActiveProfileActions.AddCustomGameAction(gameAction));
     }
 
+    public editCustomGameActionByIndex(index: number, gameAction: GameAction): Observable<unknown> {
+        return this.store.dispatch(new ActiveProfileActions.EditCustomGameAction(index, gameAction));
+    }
+
     public removeCustomGameActionByIndex(index: number): Observable<unknown> {
         return this.store.dispatch(new ActiveProfileActions.RemoveCustomGameAction(index));
     }

src/app/state/active-profile/active-profile.actions.ts

@@ -137,6 +137,15 @@ export namespace ActiveProfileActions {
         ) {}
     }
 
+    export class EditCustomGameAction {
+        public static readonly type = `[activeProfile] edit custom game action`;
+
+        constructor(
+            public gameActionIndex: number,
+            public gameAction: GameAction
+        ) {}
+    }
+
     export class RemoveCustomGameAction {
         public static readonly type = `[activeProfile] remove custom game action`;
 

src/app/state/active-profile/active-profile.state.ts

@@ -328,6 +328,19 @@ export class ActiveProfileState {
         context.setState(state);
     }
 
+    @Action(ActiveProfileActions.EditCustomGameAction)
+    public editCustomGameAction(context: ActiveProfileState.Context, { gameActionIndex, gameAction }: ActiveProfileActions.EditCustomGameAction): void {
+        const state = _.cloneDeep(context.getState()!);
+
+        if (state.customGameActions && gameActionIndex < state.customGameActions.length) {
+            state.customGameActions[gameActionIndex] = gameAction;
+        } else {
+            log.error("Tried to edit game action at invalid index", gameActionIndex);
+        }
+
+        context.setState(state);
+    }
+
     @Action(ActiveProfileActions.RemoveCustomGameAction)
     public removeCustomGameAction(context: ActiveProfileState.Context, { gameActionIndex }: ActiveProfileActions.RemoveCustomGameAction): void {
         const state = _.cloneDeep(context.getState()!);

src/electron.js

@@ -87,11 +87,9 @@ class ElectronLoader {
     constructor() {
         log.initialize();
 
-        if (DEBUG_MODE) {
-            log.transports.console.level = "debug";
-        }
-
-        log.transports.file.level = DEBUG_MODE ? "info" : "debug";
+        log.transports.ipc.level = DEBUG_MODE ? "debug" : "info";
+        log.transports.console.level = DEBUG_MODE ? "debug" : "info";
+        log.transports.file.level = DEBUG_MODE ? "debug" : "info";
         log.transports.file.resolvePathFn = () => "app.log";
 
         this.menu = this.createMenu();
@@ -331,9 +329,9 @@ class ElectronLoader {
             return this.deleteProfile(profile);
         });
 
-        ipcMain.handle("app:copyProfileData", async (
+        ipcMain.handle("app:copyProfile", async (
             _event,
-            /** @type {import("./app/models/app-message").AppMessageData<"app:copyProfileData">} */ { srcProfile, destProfile }
+            /** @type {import("./app/models/app-message").AppMessageData<"app:copyProfile">} */ { srcProfile, destProfile }
         ) => {
             function shouldCopyDir(srcPath, destPath) {
                 return fs.existsSync(srcPath) && (!fs.existsSync(destPath) || fs.realpathSync(srcPath) !== fs.realpathSync(destPath));
@@ -812,7 +810,7 @@ class ElectronLoader {
 
             // Run the action
             try {
-                exec(gameActionCmd);
+                exec(gameActionCmd, { cwd: profile.gameBinaryPath });
             } catch(error) {
                 throw new Error(error.toString());
             }
@@ -1017,6 +1015,18 @@ class ElectronLoader {
                         label: "Import Profile",
                         click: () => this.mainWindow.webContents.send("app:importProfile")
                     },
+                    {
+                        label: "Copy Profile",
+                        click: () => this.mainWindow.webContents.send("app:copyProfile")
+                    },
+                    {
+                        label: "Export Profile",
+                        click: () => this.mainWindow.webContents.send("app:exportProfile")
+                    },
+                    {
+                        label: "Delete Profile",
+                        click: () => this.mainWindow.webContents.send("app:deleteProfile")
+                    },
                     {
                         type: "separator"
                     },