Skip to content

Commit 7591268

Browse files
committed
fix(FR-1383): add missing i18n key and fix HTML tooltip rendering (#4161)
Resolves #4160 ([FR-1383https://lablup.atlassian.net/browse/FR-1383)) # Fix tooltip rendering and add missing i18n key for Recently Created Sessions ## Summary Fix missing i18n key and HTML rendering issues in tooltip components. ## Issues Fixed - **Missing i18n key**: The tooltip was not displayed correctly due to the missing RecentlyCreatedSessionsTooltip key - **HTML rendering**: i18n messages containing HTML tags (e.g., p tags) were displayed as plain strings instead of rendered HTML ## Changes - ✅ Added missing RecentlyCreatedSessionsTooltip key to all 21 language files - ✅ Modified MyResource.tsx to use Trans component for proper HTML rendering in tooltips - ✅ Updated BaseResourceItem.tsx tooltip prop type from string to ReactNode to support React components - ✅ Enhanced RecentlyCreatedSession.tsx to support parameterized tooltips with count values - ✅ Added i18n-ally regex patterns to code-workspace for better i18n key detection ## Files Changed - backend.ai-webui.code-workspace - Added i18n-ally regex patterns - react/src/components/BaseResourceItem.tsx - Enhanced tooltip prop type - react/src/components/MyResource.tsx - Added Trans component usage - react/src/components/RecentlyCreatedSession.tsx - Added count parameter support - resources/i18n/*.json (21 files) - Added missing translation key
1 parent 2ad58c7 commit 7591268

File tree

24 files changed

+27
-4
lines changed

24 files changed

+27
-4
lines changed

react/src/components/BaseResourceItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export interface AcceleratorSlotDetail {
3030
export interface BaseResourceItemProps {
3131
title: ReactNode | string;
3232
titleStyle?: React.CSSProperties;
33-
tooltip?: string;
33+
tooltip?: ReactNode;
3434
isRefetching?: boolean;
3535
displayType: 'usage' | 'remaining';
3636
onDisplayTypeChange: (type: 'usage' | 'remaining') => void;

react/src/components/MyResource.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { Typography } from 'antd';
1414
import { BAICardProps, BAIFlex } from 'backend.ai-ui';
1515
import _ from 'lodash';
1616
import { useCallback, useMemo, useState } from 'react';
17-
import { useTranslation } from 'react-i18next';
17+
import { Trans, useTranslation } from 'react-i18next';
1818

1919
interface MyResourceProps extends BAICardProps {
2020
fetchKey?: string;
@@ -135,7 +135,7 @@ const MyResource: React.FC<MyResourceProps> = ({
135135
</Typography.Title>
136136
</BAIFlex>
137137
}
138-
tooltip={t('webui.menu.MyResourcesDescription')}
138+
tooltip={<Trans i18nKey={'webui.menu.MyResourcesDescription'} />}
139139
isRefetching={isRefetching || internalIsRefetching}
140140
displayType={type}
141141
onDisplayTypeChange={setType}

react/src/components/RecentlyCreatedSession.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ const RecentlyCreatedSession: React.FC<RecentlyCreatedSessionProps> = ({
7070
>
7171
<BAIBoardItemTitle
7272
title={t('session.RecentlyCreatedSessions')}
73-
tooltip={t('session.RecentlyCreatedSessionsTooltip')}
73+
tooltip={t('session.RecentlyCreatedSessionsTooltip', {
74+
count: 5,
75+
})}
7476
extra={
7577
<BAIFetchKeyButton
7678
size="small"

resources/i18n/de.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1284,6 +1284,7 @@
12841284
"ReadLess": "Weniger lesen",
12851285
"ReadMore": "Mehr lesen...",
12861286
"RecentlyCreatedSessions": "Kürzlich erstellte Sitzungen",
1287+
"RecentlyCreatedSessionsTooltip": "Zeigt die {{count}} zuletzt erstellten laufenden Sessions im aktuellen Projekt",
12871288
"RequestContainerCommit": "Container Commit anfordern",
12881289
"Reservation": "Reservierung",
12891290
"ResourceGroup": "Ressourcengruppe",

resources/i18n/el.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1282,6 +1282,7 @@
12821282
"ReadLess": "Διαβάστε λιγότερα",
12831283
"ReadMore": "Διαβάστε Περισσότερα...",
12841284
"RecentlyCreatedSessions": "Πρόσφατα δημιουργήθηκαν συνεδρίες",
1285+
"RecentlyCreatedSessionsTooltip": "Εμφανίζει τις {{count}} πιο πρόσφατα δημιουργημένες εκτελούμενες συνεδρίες στο τρέχον έργο",
12851286
"RequestContainerCommit": "Αίτηση δέσμευσης εμπορευματοκιβωτίου",
12861287
"Reservation": "Κράτηση",
12871288
"ResourceGroup": "Ομάδα πόρων",

resources/i18n/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,6 +1291,7 @@
12911291
"ReadLess": "Read less",
12921292
"ReadMore": "Read More...",
12931293
"RecentlyCreatedSessions": "Recently Created Sessions",
1294+
"RecentlyCreatedSessionsTooltip": "Shows the {{count}} most recently created running sessions in the current project",
12941295
"RequestContainerCommit": "Request Container Commit",
12951296
"Reservation": "Reservation",
12961297
"ResourceGroup": "Resource Group",

resources/i18n/es.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,6 +1286,7 @@
12861286
"ReadLess": "Leer menos",
12871287
"ReadMore": "Leer más...",
12881288
"RecentlyCreatedSessions": "Sesiones creadas recientemente",
1289+
"RecentlyCreatedSessionsTooltip": "Muestra las {{count}} sesiones en ejecución creadas más recientemente en el proyecto actual",
12891290
"RequestContainerCommit": "Solicitud de Compromiso de Contenedor",
12901291
"Reservation": "Reserva",
12911292
"ResourceGroup": "Grupo de recursos",

resources/i18n/fi.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,6 +1285,7 @@
12851285
"ReadLess": "Lue vähemmän",
12861286
"ReadMore": "Lue lisää...",
12871287
"RecentlyCreatedSessions": "Äskettäin loivat istunnot",
1288+
"RecentlyCreatedSessionsTooltip": "Näyttää {{count}} viimeisintä luotua käynnissä olevaa istuntoa nykyisessä projektissa",
12881289
"RequestContainerCommit": "Pyyntö Container Commit",
12891290
"Reservation": "Varaukset",
12901291
"ResourceGroup": "Resurssiryhmä",

resources/i18n/fr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,6 +1286,7 @@
12861286
"ReadLess": "Lire moins",
12871287
"ReadMore": "Lire la suite...",
12881288
"RecentlyCreatedSessions": "Sessions récemment créées",
1289+
"RecentlyCreatedSessionsTooltip": "Affiche les {{count}} sessions en cours d'exécution les plus récemment créées dans le projet actuel",
12891290
"RequestContainerCommit": "Demande de conteneur Engagement",
12901291
"Reservation": "Réservation",
12911292
"ResourceGroup": "Groupe de ressources",

resources/i18n/id.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1284,6 +1284,7 @@
12841284
"ReadLess": "Baca lebih sedikit",
12851285
"ReadMore": "Baca Selengkapnya...",
12861286
"RecentlyCreatedSessions": "Sesi yang baru dibuat",
1287+
"RecentlyCreatedSessionsTooltip": "Menampilkan {{count}} sesi yang sedang berjalan yang baru dibuat di proyek saat ini",
12871288
"RequestContainerCommit": "Permintaan Komitmen Kontainer",
12881289
"Reservation": "Reservasi",
12891290
"ResourceGroup": "Grup Sumber Daya",

0 commit comments

Comments
 (0)