Skip to content

Commit 779b8a8

Browse files
committed
Fixed email attachment/inline
Signed-off-by: Vishal Rana <vr@labstack.com>
1 parent bf40841 commit 779b8a8

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

email/email.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"bytes"
55
"crypto/tls"
66
"html/template"
7-
"mime/quotedprintable"
87
"net/mail"
98
"net/smtp"
109

@@ -67,22 +66,21 @@ func (m *Message) writeBoundary() {
6766
func (m *Message) writeText(content string, contentType string) {
6867
m.writeBoundary()
6968
m.writeHeader("Content-Type", contentType+"; charset=UTF-8")
70-
m.writeHeader("Content-Transfer-Encoding", "quoted-printable")
7169
m.buffer.WriteString("\r\n")
72-
qp := quotedprintable.NewWriter(m.buffer)
73-
defer qp.Close()
74-
qp.Write([]byte(content))
70+
m.buffer.WriteString(content)
71+
m.buffer.WriteString("\r\n")
7572
m.buffer.WriteString("\r\n")
7673
}
7774

7875
func (m *Message) writeFile(f *File, disposition string) {
7976
m.writeBoundary()
80-
m.writeHeader("Content-Type", f.Type+"; name="+f.Name)
81-
m.writeHeader("Content-Disposition", disposition+"; filename="+f.Name)
77+
m.writeHeader("Content-Type", f.Type+`; name="`+f.Name+`"`)
78+
m.writeHeader("Content-Disposition", disposition+`; filename="`+f.Name+`"`)
8279
m.writeHeader("Content-Transfer-Encoding", "base64")
8380
m.buffer.WriteString("\r\n")
8481
m.buffer.WriteString(f.Content)
8582
m.buffer.WriteString("\r\n")
83+
m.buffer.WriteString("\r\n")
8684
}
8785

8886
func (e *Email) Send(m *Message) (err error) {
@@ -117,14 +115,14 @@ func (e *Email) Send(m *Message) (err error) {
117115
// TODO:
118116
}
119117

120-
// Attachments / inlines
118+
// Inlines/attachments
121119
for _, f := range m.Inlines {
122120
m.writeFile(f, "inline")
123121
}
124122
for _, f := range m.Attachments {
125-
m.writeFile(f, "disposition")
123+
m.writeFile(f, "attachment")
126124
}
127-
m.buffer.WriteString("\r\n\r\n--")
125+
m.buffer.WriteString("--")
128126
m.buffer.WriteString(m.boundary)
129127
m.buffer.WriteString("--")
130128

0 commit comments

Comments
 (0)