Skip to content

refactor(l1): make lookup interval adjustable between initial_lookup and lookup #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

refactor(l1): make lookup interval adjustable between initial_lookup and lookup #5308

wants to merge 11 commits into from

Conversation

@cdiielsi
Copy link
Contributor

@cdiielsi cdiielsi commented Nov 12, 2025

Motivation

Description

Closes #issue_number

@github-actions github-actions bot added the L1 Ethereum client label Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

Lines of code report

Total lines added: 5
Total lines removed: 5
Total lines changed: 10

Detailed view 
+---------------------------------------------------+-------+------+
| File                                              | Lines | Diff |
+---------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/discv4/peer_table.rs | 911   | +5   |
+---------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/discv4/server.rs     | 493   | -2   |
+---------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/initiator.rs    | 108   | -3   |
+---------------------------------------------------+-------+------+

cdiielsi
cdiielsi commented Nov 12, 2025
View reviewed changes
cdiielsi
cdiielsi commented Nov 12, 2025
View reviewed changes
cdiielsi
cdiielsi commented Nov 13, 2025
View reviewed changes
crates/networking/p2p/rlpx/initiator.rs Outdated
} else {
debug!("Reached target number of peers. Using longer lookup interval.");
self.lookup_interval
if num_peers + num_contacts > self.target_peers + TARGET_CONTACTS as u64 {
Copy link
Contributor Author

@cdiielsi cdiielsi Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue?: target_peers isn't necessarily the same used in Discovery

@mpaulucci mpaulucci closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cdiielsi cdiielsi

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdiielsi @mpaulucci