fix(vertexai): add timeout parameter support to ChatVertexAI and VertexAI #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added timeout parameter support to
ChatVertexAIandVertexAIclasses to control API request timeouts.Relevant issues
Fixes #1286
Type
🆕 New Feature
🐛 Bug Fix
✅ Test
Changes
ChatVertexAIandVertexAI_VertexAICommonparent class (also used byChatAnthropicVertex)ChatVertexAItimeout (streaming and non-streaming modes)VertexAItimeout parameter pass-throughtest_anthropic_utils.py(auto-formatted bymake format)Testing
All new and existing tests pass:
2 new integration tests:
test_chat_vertexai_timeout_non_streaming()- verifies timeout in non-streaming modetest_chat_vertexai_timeout_streaming()- verifies timeout in streaming mode1 new unit test:
test_timeout_parameter()- verifies timeout parameter is passed to underlying clientAdditionally:
Note
ChatAnthropicVertexalready had timeout support (now inherited from_VertexAICommon). No new tests were added for this class to keep changes minimal per contribution guidelines.