-
Notifications
You must be signed in to change notification settings - Fork 20k
milvus: add array data type for collection create #23219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
b1b11de
add array data type for milvus vector store collection create
275ea24
add array data type for milvus vector store collection create
a8e2d08
add array data type for milvus vector store collection create
c7fe30c
Merge branch 'master' into array_data_type
rgupta2508 3ab4b6c
add array data type for milvus vector store collection create
91635fa
add array data type for milvus vector store collection create
d3012fd
add array data type for milvus vector store collection create
bc33253
add array data type for milvus vector store collection create
c77b03a
Merge branch 'master' into array_data_type
rgupta2508 a4ce1a9
add array data type for milvus vector store collection create
9f70ca7
add array data type for milvus vector store collection create
b8b94bd
add array data type for milvus vector store collection create
2b5d0cf
add array data type for milvus vector store collection create
cecd707
add array data type for milvus vector store collection create
d6b90f7
add array data type for milvus vector store collection create
8ea4186
Merge branch 'master' into array_data_type
rgupta2508 fb3ed0f
add array data type for milvus vector store collection create
7719a0d
add array data type for milvus vector store collection create
0e22cff
add array data type for milvus vector store collection create
afd0140
Merge branch 'master' into array_data_type
rgupta2508 3601c2d
add array data type for milvus vector store collection create
ae234cb
update
8fa2512
Merge branch 'master' into array_data_type
rgupta2508 2b9d310
lint error
c25cd52
lint error
99f8db8
lint error
8585008
lint error
410d616
lint error
f94a687
Merge branch 'master' into array_data_type
rgupta2508 9ae4191
Merge branch 'master' into array_data_type
rgupta2508 3195bca
resolve comments
ce58e66
incorporate review comments
66101e7
incorporate review comments
d14cd87
incorporate review comments
4f8f1c4
incorporate review comments
e31a606
incorporate review comments
6ec9b86
incorporate review comments
c171cd5
Merge branch 'master' into array_data_type
rgupta2508 63387b1
partners[milvus]: refine milvus array dtype
zc277584121 798dcb8
Merge branch 'master' into array_data_type
zc277584121 f82668f
Merge branch 'master' into array_data_type
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to still rely on the solution of the pymilvus problem. It seems that pymilvus needs to support return DataType.ARRAY and other informations, before this line of code can take effect milvus-io/pymilvus#2144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, could you please add the corresponding unit test as the guarantee to the quality of other possible future PRs