-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(community): possible race condition on FileSystemChatMessageHistory #9436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(community): possible race condition on FileSystemChatMessageHistory #9436
Conversation
🦋 Changeset detectedLatest commit: 411df8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I can see the |
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the PR is not complete?
|
@christian-bromann It's surprising but complete :) I started initially by refactoring the code to use file descriptors, but it turned out that the first |
|
Bumping this, @christian-bromann / @hntrl could you review this one? Just confirming that removing this single line is the fix 🙂 |
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Good catch!
Fixes a small possible race condition on FileSystemChatMessageHistory, and removes unneeded extra check