-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[12.x] Introduce WithCachedConfig testing trait
#57663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
773ee89
with cached routes
cosmastech cd4000c
clean up
cosmastech e1ac69c
clean up
cosmastech 0490096
try to guess how Taylor would format it
cosmastech f473558
compile to array
cosmastech b606fdd
Update WithCachedRoutes.php
cosmastech 45bc684
I think this is better
cosmastech 33a4800
comments
cosmastech 3c84de0
lighter check first
cosmastech d5024c2
static
cosmastech ea9a089
formatting
taylorotwell 1797e4f
wip
cosmastech 348aed8
WithCachedConfig
cosmastech 4a5c4d0
thanks static analysis
cosmastech c8fc780
Update TestCase.php
cosmastech 700fb37
Update WithCachedConfig.php
cosmastech 0cb7a12
Update TestCase.php
cosmastech f437635
Merge remote-tracking branch 'origin/12.x' into with-cached-config
cosmastech 19018f4
Merge branch '12.x' into with-cached-config
cosmastech 420ea0c
formatting
taylorotwell a65ebac
Update WithCachedConfig.php
taylorotwell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,5 @@ | |
| class CachedState | ||
| { | ||
| public static array $cachedRoutes; | ||
| public static array $cachedConfig; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Foundation\Testing; | ||
|
|
||
| use Illuminate\Foundation\Application; | ||
| use Illuminate\Foundation\Bootstrap\LoadConfiguration; | ||
| use Illuminate\Foundation\Support\Providers\RouteServiceProvider; | ||
|
|
||
| trait WithCachedConfig | ||
| { | ||
| protected function setUpWithCachedConfig(): void | ||
| { | ||
| if ((CachedState::$cachedConfig ?? null) === null) { | ||
| CachedState::$cachedConfig = $this->app->make('config')->all(); | ||
| } | ||
|
|
||
| $this->markConfigCached($this->app); | ||
| } | ||
|
|
||
| protected function tearDownWithCachedConfig(): void | ||
| { | ||
| LoadConfiguration::setAlwaysUseConfig(null); | ||
| } | ||
|
|
||
| /** | ||
| * Inform the container to treat configuration as cached. | ||
| */ | ||
| protected function markConfigCached(Application $app): void | ||
| { | ||
| $app->instance('config_loaded_from_cache', true); // I'm not sure this is actually needed | ||
|
|
||
| LoadConfiguration::setAlwaysUseConfig(static fn () => CachedState::$cachedConfig); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any concern here about someone storing an object in cache that can be modified between tests? We could serialize/unserialize it on each test. This would cost some CPU cycles for each test, but could insulate us from that problem. Not sure how often people are storing mutable objects in their configurations 🤔