Skip to content

Conversation

@geisi
Copy link

@geisi geisi commented Nov 19, 2025

Hi Laravel team,

This PR updates the Laravel Vue Starter kit to the recently deployed v4 Version of Shadcn Vue.

unovue/shadcn-vue#1515

I think this is a good moment to do that, since Shadcn Vue has updated their docs to v4 only.

The legacy docs are still accessible here:

https://v3.shadcn-vue.com/

Without this change, developers will encounter errors when adding some Shadcn (e.g., Calendar) components or using code snippets from the docs.

Please note that the default style is now deprecated with v4. That's why I have changed it to new-york instead.

I have re-added all the components used from the starter kit. And tested the whole UI, everything works, and is now using the New York styling instead with v4 components.

I think this is the best baseline to prevent developer frustration when working with this starter kit.

@taylorotwell
Copy link
Member

taylorotwell commented Nov 27, 2025

All of the changes from single to double quotes make it extremely hard to tell what is actually changed here. 🫠

Can you only make this PR include the real changes?

@geisi
Copy link
Author

geisi commented Nov 28, 2025

@taylorotwell You're absolutely right! 🙂
I’ve re-imported all Shadcn components used by the Vue Starter Kit so the styling and formatting now match the original Shadcn components exactly.

For example, see the Avatar.vue component here:
https://github.com/unovue/shadcn-vue/blob/dev/apps/v4/registry/new-york-v4/ui/avatar/Avatar.vue

To preserve the original Shadcn styling, the Starter Kit excludes all UI components from ESLint — so I believe this behavior is intentional.

From a DX perspective, I think this is the best approach, as keeping the Shadcn styling unchanged helps avoid confusion when developers add or override components with newer Shadcn versions.

If you’d prefer not to keep the original Shadcn components exactly as they are, just let me know, and I’ll apply ESLint fixes to the modified files.

@Plytas
Copy link
Contributor

Plytas commented Nov 28, 2025

@geisi looks like you forgot to push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants