Skip to content

Commit 2fc5d43

Browse files
authored
chore: Remove duplicate version from "all" (#38)
This action determines which versions of go we are supporting, including a latest, penultimate, and a minimum version. When the minimum and penultimate are the same version, we would have duplicate entries. This would lead to multiple runs of the same sets of tests (which would be fine), but failed when the test results were uploaded, due to naming collisions.
1 parent 3a5523a commit 2fc5d43

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/go-versions.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,12 @@ jobs:
4545
- uses: actions/checkout@v4
4646
- name: Set Go Versions
4747
id: set-env
48-
run: cat ./.github/variables/go-versions.env > $GITHUB_OUTPUT
48+
run: cat ./.github/variables/go-versions.env > $GITHUB_OUTPUT
4949
- name: Set Go Version Matrices
5050
id: set-matrix
5151
run: |
52-
echo "all=[\"${{ steps.set-env.outputs.latest }}\",\"${{ steps.set-env.outputs.penultimate }}\",\"${{ steps.set-env.outputs.min }}\"]" >> $GITHUB_OUTPUT
52+
if [ "${{ steps.set-env.outputs.penultimate }}" == "${{ steps.set-env.outputs.min }}" ]; then
53+
echo "all=[\"${{ steps.set-env.outputs.latest }}\",\"${{ steps.set-env.outputs.penultimate }}\"]" >> $GITHUB_OUTPUT
54+
else
55+
echo "all=[\"${{ steps.set-env.outputs.latest }}\",\"${{ steps.set-env.outputs.penultimate }}\",\"${{ steps.set-env.outputs.min }}\"]" >> $GITHUB_OUTPUT
56+
fi

0 commit comments

Comments
 (0)