Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Commit 0cfd37f

Browse files
author
Dan Richelson
committed
Address PR comments from #42 (comment) before merging all this back into master.
1 parent e1855d1 commit 0cfd37f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/main/java/com/launchdarkly/client/LDConfig.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public final class LDConfig {
2222
private static final int DEFAULT_SOCKET_TIMEOUT = 10000;
2323
private static final int DEFAULT_FLUSH_INTERVAL = 5;
2424
private static final long DEFAULT_POLLING_INTERVAL_MILLIS = 1000L;
25-
private static final long DEFAULT_START_WAIT_MILLIS = 0L;
25+
private static final long DEFAULT_START_WAIT_MILLIS = 5000L;
2626
private static final int DEFAULT_SAMPLING_INTERVAL = 0;
2727
private static final Logger logger = LoggerFactory.getLogger(LDConfig.class);
2828

@@ -96,8 +96,8 @@ public static class Builder {
9696
private boolean offline = false;
9797
private long pollingIntervalMillis = DEFAULT_POLLING_INTERVAL_MILLIS;
9898
private FeatureStore featureStore = new InMemoryFeatureStore();
99-
public long startWaitMillis = DEFAULT_START_WAIT_MILLIS;
100-
public int samplingInterval = DEFAULT_SAMPLING_INTERVAL;
99+
private long startWaitMillis = DEFAULT_START_WAIT_MILLIS;
100+
private int samplingInterval = DEFAULT_SAMPLING_INTERVAL;
101101

102102
/**
103103
* Creates a builder with all configuration parameters set to the default
@@ -329,17 +329,19 @@ public Builder pollingIntervalMillis(long pollingIntervalMillis) {
329329

330330
/**
331331
* Set how long the constructor will block awaiting a successful connection to LaunchDarkly.
332-
* Default value of 0 will not block and cause the constructor to return immediately.
332+
* Setting this to 0 will not block and cause the constructor to return immediately.
333+
* Default value: {@value #DEFAULT_START_WAIT_MILLIS}
333334
*
334-
* @param startWaitMillis
335+
*
336+
* @param startWaitMillis milliseconds to wait
335337
* @return the builder
336338
*/
337339
public Builder startWaitMillis(long startWaitMillis) {
338340
this.startWaitMillis = startWaitMillis;
339341
return this;
340342
}
341343

342-
/**
344+
/**
343345
* Enable event sampling. When set to the default of zero, sampling is disabled and all events
344346
* are sent back to LaunchDarkly. When set to greater than zero, there is a 1 in
345347
* <code>samplingInterval</code> chance events will be will be sent.

0 commit comments

Comments
 (0)