Support for indirect patch events

Author: jkodumal

src/main/java/com/launchdarkly/client/LDClient.java

@@ -53,7 +53,7 @@ public LDClient(String apiKey, LDConfig config) {
 
     if (config.stream) {
       logger.debug("Enabling streaming API");
-      this.streamProcessor = createStreamProcessor(apiKey, config);
+      this.streamProcessor = createStreamProcessor(apiKey, config, requestor);
       this.streamProcessor.subscribe();
     } else {
       logger.debug("Streaming API disabled");
@@ -69,8 +69,8 @@ protected EventProcessor createEventProcessor(String apiKey, LDConfig config) {
     return new EventProcessor(apiKey, config);
   }
 
-  protected StreamProcessor createStreamProcessor(String apiKey, LDConfig config) {
-    return new StreamProcessor(apiKey, config);
+  protected StreamProcessor createStreamProcessor(String apiKey, LDConfig config, FeatureRequestor requestor) {
+    return new StreamProcessor(apiKey, config, requestor);
   }
 
 

src/main/java/com/launchdarkly/client/StreamProcessor.java

@@ -5,6 +5,8 @@
 import org.glassfish.jersey.internal.util.collection.StringKeyIgnoreCaseMultivaluedMap;
 import org.glassfish.jersey.media.sse.InboundEvent;
 import org.glassfish.jersey.media.sse.SseFeature;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import javax.ws.rs.client.Client;
 import javax.ws.rs.client.ClientBuilder;
@@ -19,18 +21,23 @@ class StreamProcessor implements Closeable {
   private static final String PUT = "put";
   private static final String PATCH = "patch";
   private static final String DELETE = "delete";
+  private static final String INDIRECT_PATCH = "indirect/patch";
+  private static final Logger logger = LoggerFactory.getLogger(StreamProcessor.class);
 
   private final Client client;
   private final FeatureStore store;
   private final LDConfig config;
   private final String apiKey;
+  private final FeatureRequestor requestor;
   private EventSource es;
 
-  StreamProcessor(String apiKey, LDConfig config) {
+
+  StreamProcessor(String apiKey, LDConfig config, FeatureRequestor requestor) {
     this.client = ClientBuilder.newBuilder().register(SseFeature.class).build();
     this.store = new InMemoryFeatureStore();
     this.config = config;
     this.apiKey = apiKey;
+    this.requestor = requestor;
   }
 
   void subscribe() {
@@ -58,8 +65,17 @@ else if (event.getName().equals(DELETE)) {
           FeatureDeleteData data = gson.fromJson(event.readData(), FeatureDeleteData.class);
           store.delete(data.key(), data.version());
         }
+        else if (event.getName().equals(INDIRECT_PATCH)) {
+          String key = gson.fromJson(event.readData(), String.class);
+          try {
+            FeatureRep<?> feature = requestor.makeRequest(key, true);
+            store.upsert(key, feature);
+          } catch (IOException e) {
+            logger.error("Encountered exception in LaunchDarkly client", e);
+          }
+        }
         else {
-          // TODO log an error
+          logger.warn("Unexpected event found in stream: " + event.getName());
         }
       }
     };

src/test/java/com/launchdarkly/client/LDClientTest.java

@@ -20,28 +20,24 @@ public class LDClientTest extends EasyMockSupport {
 
   private CloseableHttpClient httpClient = createMock(CloseableHttpClient.class);
 
-  private EventProcessor eventProcessor = createMock(EventProcessor.class);
+  private FeatureRequestor requestor = createMock(FeatureRequestor.class);
 
   LDClient client = new LDClient("API_KEY") {
-    @Override
-    protected CloseableHttpClient createClient() {
-      return httpClient;
-    }
 
     @Override
-    protected EventProcessor createEventProcessor(String apiKey, LDConfig config) {
-      return eventProcessor;
+    protected FeatureRequestor createFeatureRequestor(String apiKey, LDConfig config) {
+      return requestor;
     }
   };
 
   @Test
   public void testExceptionThrownByHttpClientReturnsDefaultValue() throws IOException {
 
-    expect(httpClient.execute(anyObject(HttpUriRequest.class), anyObject(HttpContext.class))).andThrow(new RuntimeException());
-    replay(httpClient);
+    expect(requestor.makeRequest(anyString(), anyBoolean())).andThrow(new IOException());
+    replay(requestor);
 
-    boolean result = client.getFlag("test", new LDUser("test.key"), true);
+    boolean result = client.toggle("test", new LDUser("test.key"), true);
     assertEquals(true, result);
-    verify(httpClient);
+    verify(requestor);
   }
 }