Merge pull request #79 from launchdarkly/dr/deleteFlags

Improve FeatureStores' delete flags method

Author: drichelson

src/main/java/com/launchdarkly/client/InMemoryFeatureStore.java

@@ -105,7 +105,7 @@ public void delete(String key, int version) {
       FeatureFlag f = features.get(key);
       if (f != null && f.getVersion() < version) {
         FeatureFlagBuilder newBuilder = new FeatureFlagBuilder(f);
-        newBuilder.on(false);
+        newBuilder.deleted(true);
         newBuilder.version(version);
         features.put(key, newBuilder.build());
       } else if (f == null) {

src/main/java/com/launchdarkly/client/RedisFeatureStore.java

@@ -296,7 +296,7 @@ public void delete(String key, int version) {
       }
 
       FeatureFlagBuilder newBuilder = new FeatureFlagBuilder(feature);
-      newBuilder.on(false);
+      newBuilder.deleted(true);
       newBuilder.version(version);
       jedis.hset(featuresKey(), key, gson.toJson(newBuilder.build()));
 
@@ -424,9 +424,8 @@ private FeatureFlag getRedis(String key) {
     }
   }
 
-  private static final JedisPoolConfig getPoolConfig() {
-    JedisPoolConfig config = new JedisPoolConfig();
-    return config;
+  private static JedisPoolConfig getPoolConfig() {
+    return new JedisPoolConfig();
   }
 
 }