Address PR comments. Change test logging to use logback.

Author: Dan Richelson

build.gradle

@@ -6,18 +6,15 @@ apply plugin: 'idea'
 apply plugin: 'com.github.johnrengelman.shadow'
 
 configurations.all {
-    // check for updates every build
+    // check for updates every build for dependencies with: 'changing: true'
     resolutionStrategy.cacheChangingModulesFor 0, 'seconds'
 }
 
 repositories {
-    mavenCentral()
     mavenLocal()
-
     // Before LaunchDarkly release artifacts get synced to Maven Central they are here along with snapshots:
-    maven {
-        url "https://oss.sonatype.org/content/groups/public/"
-    }
+    maven { url "https://oss.sonatype.org/content/groups/public/" }
+    mavenCentral()
 }
 
 allprojects {
@@ -38,7 +35,7 @@ dependencies {
     compile "redis.clients:jedis:2.8.0"
     testCompile "org.easymock:easymock:3.4"
     testCompile 'junit:junit:[4.10,)'
-    testRuntime "org.slf4j:slf4j-simple:1.7.7"
+    testRuntime "ch.qos.logback:logback-classic:1.1.3"
 }
 
 jar {

src/main/java/com/launchdarkly/client/EventProcessor.java

@@ -19,12 +19,7 @@
 import java.util.concurrent.*;
 
 class EventProcessor implements Closeable {
-  ThreadFactory threadFactory = new ThreadFactoryBuilder()
-      .setDaemon(true)
-      .setNameFormat("LaunchDarkly-EventProcessor-%d")
-      .build();
-  private final ScheduledExecutorService scheduler =
-      Executors.newSingleThreadScheduledExecutor(threadFactory);
+  private final ScheduledExecutorService scheduler;
   private final Random random = new Random();
   private final BlockingQueue<Event> queue;
   private final String apiKey;
@@ -36,6 +31,11 @@ class EventProcessor implements Closeable {
     this.queue = new ArrayBlockingQueue<>(config.capacity);
     this.consumer = new Consumer(config);
     this.config = config;
+    ThreadFactory threadFactory = new ThreadFactoryBuilder()
+        .setDaemon(true)
+        .setNameFormat("LaunchDarkly-EventProcessor-%d")
+        .build();
+    this.scheduler = Executors.newSingleThreadScheduledExecutor(threadFactory);
     this.scheduler.scheduleAtFixedRate(consumer, 0, config.flushInterval, TimeUnit.SECONDS);
   }
 

src/main/java/com/launchdarkly/client/StreamProcessor.java

@@ -104,11 +104,10 @@ else if (name.equals(INDIRECT_PATCH)) {
 
       @Override
       public void onError(Throwable throwable) {
-        logger.error("Encountered exception in LaunchDarkly client: " + throwable.getMessage());
+        logger.warn("Encountered EventSource error", throwable);
       }
     };
 
-
     es = new EventSource.Builder(handler, URI.create(config.streamURI.toASCIIString() + "/features"))
         .headers(headers)
         .build();

src/test/resources/logback.xml

@@ -0,0 +1,13 @@
+<configuration>
+  <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+    <!-- encoders are assigned the type
+         ch.qos.logback.classic.encoder.PatternLayoutEncoder by default -->
+    <encoder>
+      <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36}:%line - %msg%n</pattern>
+    </encoder>
+  </appender>
+
+  <root level="debug">
+    <appender-ref ref="STDOUT" />
+  </root>
+</configuration>