Merge pull request #46 from launchdarkly/dr/fixStringCompare

drichelson · drichelson · commit d276b9799c7f · 2016-04-11T11:45:31.000-07:00
Fix string comparison
diff --git a/src/main/java/com/launchdarkly/client/Variation.java b/src/main/java/com/launchdarkly/client/Variation.java
@@ -72,7 +72,7 @@ public boolean matchTarget(LDUser user) {
     for (TargetRule target: targets) {
       // If a userTarget rule is present, nested "key" rules
       // are deprecated and should be ignored
-      if (userTarget != null && target.attribute == "key") {
+      if (userTarget != null && target.attribute.equals("key")) {
         continue;
       }
       if (target.matchTarget(user)) {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public boolean matchTarget(LDUser user) {`
`72`	`72`	`for (TargetRule target: targets) {`
`73`	`73`	`// If a userTarget rule is present, nested "key" rules`
`74`	`74`	`// are deprecated and should be ignored`
`75`		`- if (userTarget != null && target.attribute == "key") {`
	`75`	`+ if (userTarget != null && target.attribute.equals("key")) {`
`76`	`76`	`continue;`
`77`	`77`	`}`
`78`	`78`	`if (target.matchTarget(user)) {`