Style changes for conciseness/readability. Remove unused imports

Author: Dan Richelson

src/main/java/com/launchdarkly/client/CustomEvent.java

@@ -1,7 +1,6 @@
 package com.launchdarkly.client;
 
 import com.google.gson.JsonElement;
-import com.google.gson.JsonObject;
 
 class CustomEvent extends Event {
   private final JsonElement data;

src/main/java/com/launchdarkly/client/EventProcessor.java

@@ -1,7 +1,6 @@
 package com.launchdarkly.client;
 
 import com.google.gson.Gson;
-import org.apache.http.HttpResponse;
 import org.apache.http.HttpStatus;
 import org.apache.http.client.methods.CloseableHttpResponse;
 import org.apache.http.client.methods.HttpPost;

src/main/java/com/launchdarkly/client/EventSource.java

@@ -14,7 +14,6 @@
 import java.util.List;
 import java.util.concurrent.*;
 import java.util.concurrent.atomic.AtomicReference;
-import java.util.logging.Level;
 
 // EventSource class modified from
 // https://github.com/jersey/jersey/blob/master/media/sse/src/main/java/org/glassfish/jersey/media/sse/EventSource.java

src/main/java/com/launchdarkly/client/IdentifyEvent.java

@@ -1,7 +1,5 @@
 package com.launchdarkly.client;
 
-import com.google.gson.JsonObject;
-
 class IdentifyEvent extends Event {
 
   IdentifyEvent(LDUser user) {

src/main/java/com/launchdarkly/client/NewRelicReflector.java

@@ -18,9 +18,7 @@ final class NewRelicReflector {
     try {
       newRelic = Class.forName("com.newrelic.api.agent.NewRelic");
       addCustomParameter = newRelic.getDeclaredMethod("addCustomParameter", String.class, String.class);
-    } catch (ClassNotFoundException e) {
-      logger.info("No NewRelic agent detected");
-    } catch (NoSuchMethodException e) {
+    } catch (ClassNotFoundException | NoSuchMethodException e) {
       logger.info("No NewRelic agent detected");
     }
   }

src/test/java/com/launchdarkly/client/FeatureRepTest.java

@@ -1,7 +1,6 @@
 package com.launchdarkly.client;
 
 import com.google.gson.JsonPrimitive;
-import org.glassfish.jersey.server.JSONP;
 import org.junit.Test;
 
 import java.util.Arrays;
@@ -10,24 +9,24 @@
 
 public class FeatureRepTest {
 
-  private final Variation.TargetRule targetUserOn = new Variation.TargetRule("key", Collections.<JsonPrimitive>singletonList(new JsonPrimitive("targetOn@test.com")));
+  private final Variation.TargetRule targetUserOn = new Variation.TargetRule("key", Collections.singletonList(new JsonPrimitive("targetOn@test.com")));
 
-  private final Variation.TargetRule targetGroupOn = new Variation.TargetRule("groups", Arrays.<JsonPrimitive>asList(new JsonPrimitive("google"), new JsonPrimitive("microsoft")));
+  private final Variation.TargetRule targetGroupOn = new Variation.TargetRule("groups", Arrays.asList(new JsonPrimitive("google"), new JsonPrimitive("microsoft")));
 
   // GSON will deserialize numbers as decimals
-  private final Variation.TargetRule targetFavoriteNumberOn = new Variation.TargetRule("favorite_number", Arrays.<JsonPrimitive>asList(new JsonPrimitive(42)));
+  private final Variation.TargetRule targetFavoriteNumberOn = new Variation.TargetRule("favorite_number", Arrays.asList(new JsonPrimitive(42)));
 
-  private final Variation.TargetRule targetLikesCatsOn = new Variation.TargetRule("likes_cats", Arrays.<JsonPrimitive>asList(new JsonPrimitive(true)));
+  private final Variation.TargetRule targetLikesCatsOn = new Variation.TargetRule("likes_cats", Arrays.asList(new JsonPrimitive(true)));
 
-  private final Variation.TargetRule targetUserOff = new Variation.TargetRule("key", Collections.<JsonPrimitive>singletonList(new JsonPrimitive("targetOff@test.com")));
+  private final Variation.TargetRule targetUserOff = new Variation.TargetRule("key", Collections.singletonList(new JsonPrimitive("targetOff@test.com")));
 
-  private final Variation.TargetRule targetGroupOff = new Variation.TargetRule("groups", Arrays.<JsonPrimitive>asList(new JsonPrimitive("oracle")));
+  private final Variation.TargetRule targetGroupOff = new Variation.TargetRule("groups", Arrays.asList(new JsonPrimitive("oracle")));
 
-  private final Variation.TargetRule targetFavoriteNumberOff = new Variation.TargetRule("favorite_number", Arrays.<JsonPrimitive>asList(new JsonPrimitive(33.0)));
+  private final Variation.TargetRule targetFavoriteNumberOff = new Variation.TargetRule("favorite_number", Arrays.asList(new JsonPrimitive(33.0)));
 
-  private final Variation.TargetRule targetLikesDogsOff = new Variation.TargetRule("likes_dogs", Arrays.<JsonPrimitive>asList(new JsonPrimitive(false)));
+  private final Variation.TargetRule targetLikesDogsOff = new Variation.TargetRule("likes_dogs", Arrays.asList(new JsonPrimitive(false)));
 
-  private final Variation.TargetRule targetAnonymousOn = new Variation.TargetRule("anonymous", Collections.<JsonPrimitive>singletonList(new JsonPrimitive(true)));
+  private final Variation.TargetRule targetAnonymousOn = new Variation.TargetRule("anonymous", Collections.singletonList(new JsonPrimitive(true)));
 
   private final Variation<Boolean> trueVariation = new Variation.Builder<>(true, 80)
       .target(targetUserOn)

src/test/java/com/launchdarkly/client/LDClientTest.java

@@ -1,18 +1,11 @@
 package com.launchdarkly.client;
 
 import static org.easymock.EasyMock.*;
-import static org.easymock.EasyMock.createMock;
 import static org.junit.Assert.assertEquals;
 
-import org.apache.http.client.methods.CloseableHttpResponse;
-import org.apache.http.client.methods.HttpUriRequest;
 import org.apache.http.impl.client.CloseableHttpClient;
-import org.apache.http.protocol.HttpContext;
 import org.easymock.*;
-import org.junit.Before;
 import org.junit.Test;
-import org.junit.Rule;
-import org.junit.runner.RunWith;
 
 import java.io.IOException;