prepare 2.19.3 release (#235)

Author: LaunchDarklyReleaseBot

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/node:11.10.1
+      - image: cimg/node:12.22
     steps:
       - checkout
 

.ldrelease/config.yml

@@ -1,3 +1,5 @@
+version: 2
+
 repo:
   public: js-client-sdk
   private: js-client-sdk-private
@@ -6,11 +8,14 @@ publications:
   - url: https://www.npmjs.com/package/launchdarkly-js-client-sdk
     description: npm
 
-template:
-  name: npm
+jobs:
+  - docker:
+      image: node:12-buster
+    template:
+      name: npm
 
 documentation:
-  githubPages: true
+  gitHubPages: true
   title: LaunchDarkly JavaScript SDK
 
 sdk:

README.md

@@ -16,15 +16,15 @@ Note: _If you are using JavaScript in a non-browser environment,_ please see our
 
 Please note that the JavaScript SDK has two special requirements in terms of your LaunchDarkly environment. First, in terms of the credentials for your environment that appear on your [Account Settings](https://app.launchdarkly.com/settings/projects) dashboard, the JavaScript SDK uses the "Client-side ID"-- not the "SDK key" or the "Mobile key". Second, for any feature flag that you will be using in JavaScript code, you must check the "Make this flag available to client-side SDKs" box on that flag's Settings page.
 
-### ReactJS
+## ReactJS
 
 The SDK does not require any particular JavaScript framework. However, if you are using [React](https://reactjs.org/), there is an add-on to simplify use of the SDK. See [`react-client-sdk`](https://github.com/launchdarkly/react-client-sdk).
 
 ## Browser compatibility
 
 The LaunchDarkly SDK can be used in all major browsers. However, web browsers vary widely in their support of specific features and standards. Three features that are used by the LaunchDarkly SDK that may not be available on every browser are `Promise`, `EventSource`, and `document.querySelectorAll()`. For more information on whether you may need to use a polyfill to ensure compatibility, and how to do so, see ["JS SDK requirements and polyfills"](https://docs.launchdarkly.com/sdk/client-side/javascript/requirements-polyfills).
 
-### Logging
+## Logging
 
 By default, the SDK sends log output to the browser console. There are four logging levels: `debug`, `info`, `warn`, and `error`; by default, `debug` and `info` messages are hidden. See [`LDOptions.logger`](https://launchdarkly.github.io/js-client-sdk/interfaces/_launchdarkly_js_client_sdk_.ldoptions.html#logger) and [`createConsoleLogger`](https://launchdarkly.github.io/js-client-sdk/index.html#createconsolelogger) for more details.
 

docs/Makefile

@@ -17,6 +17,7 @@ html: prepare
 	../node_modules/.bin/typedoc --options typedoc.js
 	mv before-typedoc-package.json ../package.json
 	mv before-typedoc-package-lock.json ../package-lock.json
+	if [ -n "$(LD_RELEASE_DOCS_DIR)" ]; then cp -r build/html/* "$(LD_RELEASE_DOCS_DIR)"; fi
 
 prepare:
 	cp ../package.json before-typedoc-package.json

src/GoalManager.js

@@ -9,18 +9,6 @@ export default function GoalManager(clientVars, readyCallback) {
 
   const ret = {};
 
-  ret.goalKeyExists = key => {
-    if (!goals) {
-      return true;
-    }
-    for (let i = 0; i < goals.length; i++) {
-      if (goals[i].kind === 'custom' && goals[i].key === key) {
-        return true;
-      }
-    }
-    return false;
-  };
-
   function getGoalsPath() {
     return '/sdk/goals/' + clientVars.getEnvironmentId();
   }

src/__tests__/LDClient-test.js

@@ -1,6 +1,5 @@
 import sinon from 'sinon';
 
-import * as common from 'launchdarkly-js-sdk-common';
 import * as LDClient from '../index';
 import * as pkg from '../../package.json';
 
@@ -148,15 +147,16 @@ describe('LDClient', () => {
       expect(errorSpy).not.toHaveBeenCalled();
     });
 
-    it('should warn when tracking an unknown custom goal event', async () => {
+    it('should not warn when tracking an unknown custom goal event', async () => {
       server.respondWith([200, { 'Content-Type': 'application/json' }, '[{"key": "known", "kind": "custom"}]']);
 
       const client = LDClient.initialize(envName, user, { bootstrap: {}, sendEvents: false });
       await client.waitForInitialization();
       await client.waitUntilGoalsReady();
 
       client.track('unknown');
-      expect(warnSpy).toHaveBeenCalledWith('LD: [warn] ' + common.messages.unknownCustomEventKey('unknown'));
+      expect(warnSpy).not.toHaveBeenCalled();
+      expect(errorSpy).not.toHaveBeenCalled();
     });
   });
 

src/index.js

@@ -29,8 +29,9 @@ export function initialize(env, user, options = {}) {
   client.waitUntilGoalsReady = () => goalsPromise;
 
   if (validatedOptions.fetchGoals) {
-    const goalManager = GoalManager(clientVars, () => emitter.emit(goalsEvent));
-    platform.customEventFilter = goalManager.goalKeyExists;
+    GoalManager(clientVars, () => emitter.emit(goalsEvent));
+    // Don't need to save a reference to the GoalManager - its constructor takes care of setting
+    // up the necessary event wiring
   } else {
     emitter.emit(goalsEvent);
   }