prepare 4.0.1 release (#58)

Author: LaunchDarklyReleaseBot

.circleci/config.yml

@@ -8,7 +8,6 @@ jobs:
 
       - run: npm install
       - run: npm run lint:all
-      - run: npm run build:min
       - run:
           command: npm test
           environment:

CONTRIBUTING.md

@@ -37,3 +37,9 @@ To verify that the TypeScript declarations compile correctly (this involves comp
 ```
 npm run check-typescript
 ```
+
+### Coding guidelines
+
+This code is shared between several SDK projects: `js-client-sdk` which runs in browsers, `node-client-sdk` which runs in Node.js, and `electron-client-sdk` which uses it both in a Node environment and in a browser environment.
+
+Therefore, it should not have any JavaScript usages that work _only_ in a browser or _only_ in Node.js. All such things, if they depend on the runtime environment, must be accessed indirectly via the "platform" abstraction, where each SDK provides its own platform-specific callbacks for the `js-sdk-common` code to use. Or, if it's just a question of JavaScript syntax usages, use whatever will work in both browsers and Node (for instance, use only `require` and `module.exports`, not ES6 imports).

docs/typedoc.js

@@ -4,20 +4,8 @@
   "description": "LaunchDarkly SDK for JavaScript - common code",
   "author": "LaunchDarkly <team@launchdarkly.com>",
   "license": "Apache-2.0",
-  "files": [
-    "ldclient-common.cjs.js",
-    "ldclient-common.cjs.js.map",
-    "ldclient-common.es.js",
-    "ldclient-common.es.js.map",
-    "ldclient-common.min.js",
-    "ldclient-common.min.js.map",
-    "typings.d.ts"
-  ],
   "types": "./typings.d.ts",
-  "main": "dist/ldclient-common.cjs.js",
-  "module": "dist/ldclient-common.es.js",
-  "unpkg": "dist/ldclient-common.min.js",
-  "jsdelivr": "dist/ldclient-common.min.js",
+  "main": "src/index.js",
   "scripts": {
     "lint": "eslint --format 'node_modules/eslint-formatter-pretty' --ignore-path .eslintignore",
     "lint:all": "eslint --format 'node_modules/eslint-formatter-pretty' --ignore-path .eslintignore src",
@@ -27,14 +15,8 @@
     "format:test": "npm run format:test:md && npm run format:test:js",
     "format:test:md": "prettier --parser markdown --ignore-path .prettierignore --list-different '*.md'",
     "format:test:js": "prettier --ignore-path .prettierignore --list-different 'src/**/*.js'",
-    "build": "cross-env NODE_ENV=development rollup -c rollup.config.js",
-    "build:min": "cross-env NODE_ENV=production rollup -c rollup.config.js",
     "test": "cross-env NODE_ENV=test jest",
-    "test:junit": "cross-env NODE_ENV=test jest --testResultsProcessor jest-junit",
-    "check-typescript": "node_modules/typescript/bin/tsc",
-    "clean": "rimraf dist/**",
-    "prepublishOnly": "npm run build:min",
-    "prepare": "npm run build"
+    "check-typescript": "node_modules/typescript/bin/tsc"
   },
   "devDependencies": {
     "@babel/cli": "^7.8.4",
@@ -43,7 +25,6 @@
     "@babel/plugin-transform-runtime": "^7.6.2",
     "@babel/preset-env": "^7.6.3",
     "@babel/runtime": "7.6.3",
-    "@rollup/plugin-node-resolve": "^6.0.0",
     "@rollup/plugin-replace": "^2.2.0",
     "babel-eslint": "^10.1.0",
     "babel-jest": "^25.1.0",
@@ -59,13 +40,6 @@
     "launchdarkly-js-test-helpers": "1.1.0",
     "prettier": "1.11.1",
     "readline-sync": "^1.4.9",
-    "rimraf": "^2.6.2",
-    "rollup": "^1.26.0",
-    "rollup-plugin-babel": "^4.3.3",
-    "rollup-plugin-commonjs": "^10.1.0",
-    "rollup-plugin-filesize": "^6.2.1",
-    "rollup-plugin-terser": "5.2.0",
-    "rollup-plugin-uglify": "6.0.4",
     "semver": "^5.5.0",
     "semver-compare": "^1.0.0",
     "typescript": "~4.4.4"

package.json

@@ -1,4 +1,4 @@
-export default function EventEmitter(logger) {
+function EventEmitter(logger) {
   const emitter = {};
   const events = {};
 
@@ -56,3 +56,5 @@ export default function EventEmitter(logger) {
   };
   return emitter;
 }
+
+module.exports = EventEmitter;

rollup.config.js

@@ -1,11 +1,11 @@
-import EventSender from './EventSender';
-import EventSummarizer from './EventSummarizer';
-import UserFilter from './UserFilter';
-import * as errors from './errors';
-import * as messages from './messages';
-import * as utils from './utils';
+const EventSender = require('./EventSender');
+const EventSummarizer = require('./EventSummarizer');
+const UserFilter = require('./UserFilter');
+const errors = require('./errors');
+const messages = require('./messages');
+const utils = require('./utils');
 
-export default function EventProcessor(
+function EventProcessor(
   platform,
   options,
   environmentId,
@@ -171,3 +171,5 @@ export default function EventProcessor(
 
   return processor;
 }
+
+module.exports = EventProcessor;

src/EventEmitter.js

@@ -1,10 +1,10 @@
-import * as errors from './errors';
-import * as utils from './utils';
+const errors = require('./errors');
+const utils = require('./utils');
 const { v1: uuidv1 } = require('uuid');
 
 const MAX_URL_LENGTH = 2000;
 
-export default function EventSender(platform, environmentId, options) {
+function EventSender(platform, environmentId, options) {
   const imageUrlPath = '/a/' + environmentId + '.gif';
   const baseHeaders = utils.extend({ 'Content-Type': 'application/json' }, utils.getLDHeaders(platform, options));
   const httpFallbackPing = platform.httpFallbackPing; // this will be set for us if we're in the browser SDK
@@ -83,3 +83,5 @@ export default function EventSender(platform, environmentId, options) {
 
   return sender;
 }
+
+module.exports = EventSender;

src/EventProcessor.js

@@ -1,4 +1,4 @@
-export default function EventSummarizer() {
+function EventSummarizer() {
   const es = {};
 
   let startDate = 0,
@@ -80,3 +80,5 @@ export default function EventSummarizer() {
 
   return es;
 }
+
+module.exports = EventSummarizer;

src/EventSender.js

@@ -1,6 +1,6 @@
-import * as utils from './utils';
+const utils = require('./utils');
 
-export default function Identity(initialUser, onChange) {
+function Identity(initialUser, onChange) {
   const ident = {};
   let user;
 
@@ -22,3 +22,5 @@ export default function Identity(initialUser, onChange) {
 
   return ident;
 }
+
+module.exports = Identity;