Merge pull request #2 from launchdarkly/pk/missing-key-warning

Avoid logging a warning for a missing sdk key when importing ldclient…

Author: pkaeding

ldclient/client.py

@@ -39,6 +39,7 @@ def __init__(self, sdk_key=None, config=None, start_wait=5):
             self._config = Config(sdk_key=sdk_key)
         else:
             self._config = config or Config.default()
+        self._config._validate()
 
         self._session = CacheControl(requests.Session())
         self._queue = queue.Queue(self._config.events_max_pending)

ldclient/config.py

@@ -39,8 +39,6 @@ def __init__(self,
         :param event_consumer_class: A factory for an EventConsumer implementation taking the event queue, sdk key, and config
         :type event_consumer_class: (queue.Queue, str, Config) -> EventConsumer
         """
-        if offline is False and sdk_key is None or sdk_key is '':
-            log.warn("Missing or blank sdk_key.")
         self.__sdk_key = sdk_key
 
         if defaults is None:
@@ -168,3 +166,7 @@ def verify_ssl(self):
     @property
     def offline(self):
         return self.__offline
+
+    def _validate(self):
+        if self.offline is False and self.sdk_key is None or self.sdk_key is '':
+            log.warn("Missing or blank sdk_key.")