fix lint issues

Author: jsonbailey

ldclient/config.py

@@ -9,7 +9,11 @@
 
 from ldclient.feature_store import InMemoryFeatureStore
 from ldclient.hook import Hook
-from ldclient.impl.util import log, validate_application_info, validate_sdk_key_format
+from ldclient.impl.util import (
+    log,
+    validate_application_info,
+    validate_sdk_key_format
+)
 from ldclient.interfaces import (
     BigSegmentStore,
     DataSourceUpdateSink,

ldclient/impl/util.py

@@ -61,7 +61,7 @@ def validate_application_value(value: Any, name: str, logger: logging.Logger) ->
 def validate_sdk_key_format(sdk_key: str, logger: logging.Logger) -> str:
     """
     Validates that an SDK key does not contain invalid characters and is not too long for our systems.
-    
+
     :param sdk_key: the SDK key to validate
     :param logger: the logger to use for logging warnings
     :return: the validated SDK key, or empty string if the SDK key is invalid
@@ -71,15 +71,12 @@ def validate_sdk_key_format(sdk_key: str, logger: logging.Logger) -> str:
 
     if not isinstance(sdk_key, str):
         return ""
-    
     if len(sdk_key) > _MAX_SDK_KEY_LENGTH:
         logger.warning('SDK key was longer than %d characters and was discarded' % _MAX_SDK_KEY_LENGTH)
         return ""
-    
     if _VALID_CHARACTERS_REGEX.search(sdk_key):
         logger.warning('SDK key contained invalid characters and was discarded')
         return ""
-    
     return sdk_key
 
 

ldclient/testing/impl/test_util.py

@@ -1,4 +1,5 @@
 import logging
+
 from ldclient.impl.util import validate_sdk_key_format
 
 
@@ -12,7 +13,7 @@ def test_validate_sdk_key_format_valid():
         "test.key_with.dots",
         "test-key-with-hyphens"
     ]
-    
+
     for key in valid_keys:
         result = validate_sdk_key_format(key, logger)
         assert result == key  # Should return the same key if valid
@@ -23,13 +24,13 @@ def test_validate_sdk_key_format_invalid():
     logger = logging.getLogger('test')
     invalid_keys = [
         "sdk-key-with-\x00-null",
-        "sdk-key-with-\n-newline", 
+        "sdk-key-with-\n-newline",
         "sdk-key-with-\t-tab",
         "sdk key with spaces",
         "sdk@key#with$special%chars",
         "sdk/key\\with/slashes"
     ]
-    
+
     for key in invalid_keys:
         result = validate_sdk_key_format(key, logger)
         assert result == ''  # Should return empty string for invalid keys
@@ -39,7 +40,7 @@ def test_validate_sdk_key_format_non_string():
     """Test validation of non-string SDK keys"""
     logger = logging.getLogger('test')
     non_string_values = [123, object(), [], {}]
-    
+
     for value in non_string_values:
         result = validate_sdk_key_format(value, logger)
         assert result == ''  # Should return empty string for non-string values
@@ -58,7 +59,7 @@ def test_validate_sdk_key_format_max_length():
     valid_key = "a" * 8192
     result = validate_sdk_key_format(valid_key, logger)
     assert result == valid_key  # Should return the same key if valid
-    
+
     invalid_key = "a" * 8193
     result = validate_sdk_key_format(invalid_key, logger)
     assert result == ''  # Should return empty string for keys that are too long

ldclient/testing/test_config.py

@@ -54,7 +54,7 @@ def test_sdk_key_validation_valid_keys():
         "test.key_with.dots",
         "test-key-with-hyphens"
     ]
-    
+
     for key in valid_keys:
         config = Config(sdk_key=key)
         assert config.sdk_key == key
@@ -70,7 +70,7 @@ def test_sdk_key_validation_invalid_keys():
         "sdk@key#with$special%chars",
         "sdk/key\\with/slashes"
     ]
-    
+
     for key in invalid_keys:
         config = Config(sdk_key=key)
         assert config.sdk_key == ''
@@ -93,7 +93,7 @@ def test_sdk_key_validation_max_length():
     valid_key = "a" * 8192
     config = Config(sdk_key=valid_key)
     assert config.sdk_key == valid_key
-    
+
     invalid_key = "a" * 8193
     config = Config(sdk_key=invalid_key)
     assert config.sdk_key == ''
@@ -102,10 +102,10 @@ def test_sdk_key_validation_max_length():
 def test_copy_with_new_sdk_key_validation():
     """Test that copy_with_new_sdk_key validates the new key"""
     original_config = Config(sdk_key="valid-key")
-    
+
     new_config = original_config.copy_with_new_sdk_key("another-valid-key")
     assert new_config.sdk_key == "another-valid-key"
-    
+
     invalid_config = original_config.copy_with_new_sdk_key("invalid key with spaces")
     assert invalid_config.sdk_key == ''