prepare 6.2.0 release (#93)

Author: eli-darkly

.circleci/config.yml

@@ -8,6 +8,7 @@ workflows:
       - test-3.4
       - test-3.5
       - test-3.6
+      - test-3.7
 test-template: &test-template
   steps:
     - checkout
@@ -59,3 +60,8 @@ jobs:
     docker:
       - image: circleci/python:3.6-jessie
       - image: redis
+  test-3.7:
+    <<: *test-template
+    docker:
+      - image: circleci/python:3.7-stretch
+      - image: redis

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the LaunchDarkly Python SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [6.2.0] - 2018-08-03
+### Changed:
+- In streaming mode, each connection failure or unsuccessful reconnection attempt logs a message at `ERROR` level. Previously, this message included the amount of time before the next retry; since that interval is different for each attempt, that meant the `ERROR`-level messages were all unique, which could cause problems for monitors. This has been changed so the `ERROR`-level message is always the same, and is followed by an `INFO`-level message about the time delay. (Note that in order to suppress the default message, the LaunchDarkly client modifies the logger used by the `backoff` package; if you are using `backoff` for some other purpose and _do_ want to see the default message, set `logging.getLogger('backoff').propagate` to `True`.) ([#88](https://github.com/launchdarkly/python-client/issues/88))
+
 ## [6.1.1] - 2018-06-19
 
 ### Fixed:

CODEOWNERS

@@ -1 +1 @@
-* @ashanbrown
+

README.md

@@ -10,6 +10,11 @@ LaunchDarkly SDK for Python
 
 [![Twitter Follow](https://img.shields.io/twitter/follow/launchdarkly.svg?style=social&label=Follow&maxAge=2592000)](https://twitter.com/intent/follow?screen_name=launchdarkly)
 
+Supported Python versions
+-------------------------
+
+This version of the LaunchDarkly SDK is compatible with Python 2.7, and Python 3.3 through 3.7.
+
 Quick setup
 -----------
 

ldclient/streaming.py

@@ -5,6 +5,7 @@
 from threading import Thread
 
 import backoff
+import logging
 import time
 
 from ldclient.interfaces import UpdateProcessor
@@ -32,6 +33,13 @@ def __init__(self, config, requester, store, ready):
         self._running = False
         self._ready = ready
 
+        # We need to suppress the default logging behavior of the backoff package, because
+        # it logs messages at ERROR level with variable content (the delay time) which will
+        # prevent monitors from coalescing multiple messages. The backoff package attempts
+        # to suppress its own output by default by giving the logger a NullHandler, but it
+        # will still propagate up to the root logger unless we do this:
+        logging.getLogger('backoff').propagate = False
+
     # Retry/backoff logic:
     # Upon any error establishing the stream connection we retry with backoff + jitter.
     # Upon any error processing the results of the stream we reconnect after one second.
@@ -65,8 +73,12 @@ def _backoff_expo():
     def should_not_retry(e):
         return isinstance(e, UnsuccessfulResponseException) and (not is_http_error_recoverable(e.status))
 
+    def log_backoff_message(props):
+        log.error("Streaming connection failed, will attempt to restart")
+        log.info("Will reconnect after delay of %fs", props['wait'])
+
     @backoff.on_exception(_backoff_expo, BaseException, max_tries=None, jitter=backoff.full_jitter,
-                          giveup=should_not_retry)
+                          on_backoff=log_backoff_message, giveup=should_not_retry)
     def _connect(self):
         return SSEClient(
             self._uri,

ldclient/version.py

@@ -1 +1 @@
-VERSION = "6.1.1"
+VERSION = "6.2.0"

setup.py

@@ -13,7 +13,7 @@ def parse_requirements(filename):
     return [line for line in lineiter if line and not line.startswith("#")]
 
 
-ldclient_version='6.1.1'
+ldclient_version='6.2.0'
 
 # parse_requirements() returns generator of pip.req.InstallRequirement objects
 install_reqs = parse_requirements('requirements.txt')