Skip to content

Commit a8f92ea

Browse files
committed
Refactor Makefile targets for clarity and consistency; update npm command in UI build process
Signed-off-by: marblom007 <158522975+marblom007@users.noreply.github.com>
1 parent 8b4b147 commit a8f92ea

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Makefile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ extension-no-cache:
3434
docker build --tag=$(IMAGE) --no-cache --build-arg GIT_VERSION=$(GIT_VERSION) --build-arg GIT_STRIPPED_VERSION=$(GIT_STRIPPED_VERSION) .
3535

3636
## Create buildx builder for multi-arch build.
37-
prepare-buildx:
37+
buildx-prepare:
3838
docker buildx inspect $(BUILDER) || docker buildx create --name=$(BUILDER) --driver=docker-container --driver-opt=network=host
3939

4040
## Build & Upload extension image to hub. Do not push if tag already exists.
41-
extension-build-push: prepare-buildx
41+
extension-build-push: buildx-prepare
4242
docker pull $(IMAGE):$(RELEASE_CHANNEL)-$(GIT_VERSION) && echo "Failure: Tag already exists" || \
4343
docker buildx build --push \
4444
--builder=$(BUILDER) --platform=linux/amd64,linux/arm64 \
@@ -55,30 +55,30 @@ ui-build:
5555

5656
## Run UI on local port
5757
ui:
58-
cd ui/src; npm run start; cd ../..;
58+
cd ui/src; npm install; npm run start; cd ../..;
5959

6060
## Make easier to debug the UI
61-
link:
61+
extension-link:
6262
docker extension dev ui-source $(IMAGE) http://localhost:3000
6363
docker extension dev debug $(NAME)
6464

6565
## docker extension dev reset
66-
reset:
66+
extension-reset:
6767
docker extension dev reset $(IMAGE)
6868

6969
## docker extension install
70-
install-extension:
70+
extension-install:
7171
docker extension install $(IMAGE) --force
7272

7373
## Remove the extension
74-
remove-extension:
74+
extension-remove:
7575
docker extension remove $(IMAGE) || true
7676

7777
## Enable debug mode for the extension
7878
enable-debug-mode:
7979
docker extension dev debug $(NAME)
8080

8181
## Build the extension and install it
82-
build-dev: remove-extension extension install-extension enable-debug-mode
82+
build-dev: extension-remove extension extension-install enable-debug-mode
8383

84-
.PHONY: prepare-buildx push-extension extension ui bin build-dev enable-debug-mode install-extension
84+
.PHONY: buildx-prepare push-extension extension ui bin build-dev enable-debug-mode extension-install extension-link extension-reset extension-remove

0 commit comments

Comments
 (0)